Add batching functionality to delete_nodes to prevent timeouts #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `delete_nodes` is given a large amount of nodes, or is instructed to recursively delete a big structure, the connection between client and server can time out. To remedy this, allow the user to supply a `batch` parameter, which controls how many nodes are deleted in one request. closes FreeOpcUa#1148
Nebukadneza
force-pushed
the
add_delete_batching
branch
from
f153459 to
13eeb18
Compare
|
why does that help? the client must anyway wait for all chunks to be processed isnt'it? |
|
Indeed, in the end the client must wait until everything is processed on serverside. However, when deleting large structures, using python-opcua as client and as server, the delete operation will time out, because the server takes to long to process the single request. Allowing to batch these into managable chunks will at least keep the network-side working, and the requests themselves won’t time-out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
delete_nodesis given a large amount of nodes, or is instructedto recursively delete a big structure, the connection between client and
server can time out.
To remedy this, allow the user to supply a
batchparameter, whichcontrols how many nodes are deleted in one request.
closes #1148