-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Make/asyncio just to easily see diff DO NOT MERGE #667
base: master
Are you sure you want to change the base?
Conversation
…es which is more reliable and has more information
# Conflicts: # examples/client-minimal-auth.py # examples/client-minimal.py # opcua/client/client.py # opcua/client/ua_client.py # opcua/common/copy_node.py # opcua/common/events.py # opcua/common/instantiate.py # opcua/common/node.py # opcua/common/ua_utils.py # opcua/server/address_space.py # opcua/server/event_generator.py # opcua/server/internal_server.py # opcua/server/server.py # opcua/server/standard_address_space/standard_address_space_part3.py # opcua/server/standard_address_space/standard_address_space_part4.py # opcua/server/standard_address_space/standard_address_space_part5.py # opcua/server/standard_address_space/standard_address_space_part8.py # opcua/server/standard_address_space/standard_address_space_part9.py # opcua/server/uaprocessor.py # opcua/ua/ua_binary.py # opcua/ua/uaprotocol_auto.py # opcua/ua/uatypes.py # schemas/AttributeIds.csv # schemas/NodeIds.csv # schemas/Opc.Ua.Adi.NodeSet2.xml # schemas/Opc.Ua.Adi.Types.bsd # schemas/Opc.Ua.Adi.Types.xsd # schemas/Opc.Ua.Endpoints.wsdl # schemas/Opc.Ua.NodeSet2.Part10.xml # schemas/Opc.Ua.NodeSet2.Part11.xml # schemas/Opc.Ua.NodeSet2.Part13.xml # schemas/Opc.Ua.NodeSet2.Part3.xml # schemas/Opc.Ua.NodeSet2.Part4.xml # schemas/Opc.Ua.NodeSet2.Part5.xml # schemas/Opc.Ua.NodeSet2.Part9.xml # schemas/Opc.Ua.NodeSet2.xml # schemas/Opc.Ua.Services.wsdl # schemas/Opc.Ua.Types.bsd # schemas/Opc.Ua.Types.xsd # schemas/StatusCode.csv # schemas/UANodeSet.xsd # schemas/generate_address_space.py # schemas/generate_model.py # tests/test_client.py # tests/test_server.py # tests/tests_common.py
Impressive work you have done.. @cbergmiller |
instanciated for every connection | ||
defined as internal class since it needs access | ||
to the internal server object | ||
FIXME: find another solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to delete that comment. It is outdated
return res | ||
return self.subscriptions[params.SubscriptionId].monitored_item_srv.delete_monitored_items( | ||
params.MonitoredItemIds) | ||
#with self._lock: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe remove these commented #with self._lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing! I will remove them once i had the time to check if they need to be replaced with a asynio.Lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact I reviewed quite a lot but could not find errors ;-) well done!
@cbergmiller I made a new repository https://github.com/FreeOpcUa/opcua-asyncio. You can push any further work directly to master until we have stabilized it. (Note it is up to date, all your work is in master) |
No description provided.