[bug]: install script fails when option --opensourceonly is supplied #145
Comments
|
This issue is not related with the install script itself but with the latest That package is installing a file named After doing this, it will only be possible to start/restart the apache service if the P.S. Changing directly a systemd file installed by a Debian package is not a good practice. If this is really required, Sangoma should instead create an override file named |
|
For some this whole comment may be just stating the obvious, but I wanted to share this to help anyone like me who doesn't know how to undo what the Issue:My installation ended with the following lines: Manually Running Solution:Lacking the knowledge of how to modify |
That's one way to do it. The other would be to edit file |
|
Basically this file was added to ensure do not start apache until we have proper ip in place, this was required due to ioncube module in apache which was causing the issue, as this is more ioncube, added fix into sysadmin/commercial module. I will soon try to modify the apache2 systemd file to take care of open source installation option as well. thanks. |
|
I would sugest to add a wrapper script that checks if #!/bin/sh
sysadmin_script=/var/www/html/admin/modules/sysadmin/hooks/check_ip_and_start_apache.sh
if [ -x "$sysadmin_script" ]; then
"$sysadmin_script"
fithat you could store, for example, as Then, use that wrapper script in an override file to the apache2 service, i.e., add a file named [Service]
ExecStartPre=/usr/bin/sysadmin_check.sh |
|
just an quick update Work is in progress to fix this issue -
"/lib/systemd/system/apache2.service.d/freepbx_apache2_systemd_override.conf"
|
|
Hi @kguptasangoma. I have some doubts that is a better option that the one I indicated previously. What will happen if someone installs a opensource only FreePBX with the install script and then, afterwards, wants some commercial modules and installs the |
|
BTW, the apache systemd override file MUST be installed in this path:
|
|
Will that apache systemd override file be installed as part of the installation process of the sysadmin module? Yes sysadmin will install this file. he/she want's to remove the sysadmin module will that override file be removed? No as of now, it will not remove the file. |
That needs to be done also, otherwise, restarting the apache service will crash after someone removes the |
|
but why would someone play to install sysadmin and then uninstall it ? also installing sysadmin means ioncube , license etc needs to install. |
|
Indeed, why would someone install sysadmin and then uninstall it? This is done by the installation script, not something a person does for fun :)
Another problem:
This is incorrect. |
|
Yea that is because we are removing commercial modules however still during uninstall added logic to remove this extra file. |
I see this usage scenario. Someone installs a FreePBX 17 with the install script and the Because of that, I find my solution better. With that, you could install the wrapper script |
|
We are removing this apache override during uninstall of sysadmin. |
OK. Don't forget to execute |
|
Fixed with Sysadmin 17.0.2.10. |
FreePBX Version
FreePBX 17
Issue Description
Installation fails if you supply the option --opensourceonly, because the file /var/www/html/admin/modules/sysadmin/hooks/check_ip_and_start_apache.sh could not be found. After creating the file, make it executable and rerun the installation-script the installation finished successfully
Operating Environment
Debian 12.7, latest installation script
Relevant log output
The text was updated successfully, but these errors were encountered: