delete all matchine local variables

they can be created in any order, so we can't rely on just checking the tail
FreeRADIUS · Sep 25, 2023 · 04fdc05 · 04fdc05
1 parent 35cf886
commit 04fdc05
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/lib/unlang/interpret.c b/src/lib/unlang/interpret.c
@@ -217,9 +217,7 @@ typedef struct {
 
 static int _local_variables_free(unlang_variable_ref_t *ref)
 {
-	fr_pair_t *vp;
-
-	while ((vp = fr_pair_list_tail(&ref->request->local_pairs)) != NULL) {
+	fr_pair_list_foreach(&ref->request->local_pairs, vp) {
 		if (vp->da->dict != ref->dict) break;
 
 		(void) fr_pair_delete(&ref->request->local_pairs, vp);