One letter expansions seem to break other expansions in the users file

[arr2036]

Issue type

• Questions about the server or its usage should be posted to the users mailing list.
• Remote security exploits MUST be sent to security@freeradius.org.
• Defect - Crash or memory corruption.
• Defect - Non compliance with a standards document, or incorrect API usage.
• [x ] Defect - Unexpected behaviour (obvious or verified by project member).
• Feature request.

See here for debugging instructions and how to obtain backtraces.

Defect/Feature description

How to reproduce issue

Use the "%T" expansion in the reply list in an entry in the users file. Not only will it not expand, but it'll break all other expansions on that lite.

[alandekok]

https://github.com/FreeRADIUS/freeradius-server/blob/v4.0.x/src/lib/util/pair.c#L2770

If you do %{User-Name} %T it works. Doing %T %{User-Name} fails.

[arr2036]

Ah, we can do much better than that now i.e. feed the string to xlat parser and see what it says.

[alandekok]

This works in v4. now that all of the problematic code has been rewritten. I've also pushed a fix for v3.2.x