Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlm_totp: Backport changes from v3.2.x #5181

Closed
wants to merge 12 commits into from

Conversation

jpereira
Copy link
Contributor

@jpereira jpereira commented Sep 15, 2023

  • Backport recent changes in rlm_totp from v3.2.x
  • Move the TOTP functionality to libfreeradius-totp.a
  • Add scripts/totp/totp-gen.py script to generate real token
  • Add a new test against rlm_totp.

e.g:

$ make test.totp
TOTP-TEST INPUT=now_token_6digits.txt TOKEN=085509 TOTP_GEN_ARGV="-d 6 -D sha1"
TOTP-TEST INPUT=now_token_8digits.txt TOKEN=43085509 TOTP_GEN_ARGV="-d 8 -D sha1"
$

@jpereira jpereira requested a review from alandekok September 17, 2023 02:23
@jpereira jpereira force-pushed the v4/rlm_totp-v32 branch 7 times, most recently from 16a61eb to e88e3d9 Compare September 21, 2023 04:14
* That script get a real token using scripts/totp/totp-gen.py
* It's validate using 'radclient' sending a valid packet.
@alandekok
Copy link
Member

I've pulled most of this over, except for a few pieces:

  • I didn't revert the call_env stuff. That is likely not too hard
  • the TOTP dictionary needs to be moved, but I ran into other issues with the dictionaries
  • the last commit for tests needs the rlm_totp without the call_env stuff, so that's been left.

But the module builds and seems to work, so that's a step forward.

@jpereira jpereira closed this Oct 4, 2023
@jpereira jpereira deleted the v4/rlm_totp-v32 branch October 4, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants