remmina: Actually install its headers. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installation of the headers in remmina/include/remmina has been broken ever since Remmina moved away from autotools, as the path specified in the call to install() did not exist. Move the install() call to remmina/ so that it works, and add a trailing / to the path so that we do not end up with $CMAKE_INSTALL_PREFIX/include/remmina/remmina.
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 31, 2014
A fix has been submitted to FreeRDP/Remmina#428. While a proper decision is not made there, just patch the code to stop calling INSTALL(DIRECTORY ...) with a path that does not exist. Until CMake 3.1.0, this would end up creating an empty directory (hence the @dir entry in the plist). The behavior has changed in 3.1.0, and we were getting build errors because we were referring to a directory that did not exist in the plist. git-svn-id: svn+ssh://svn.freebsd.org/ports/head@375903 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 31, 2014
A fix has been submitted to FreeRDP/Remmina#428. While a proper decision is not made there, just patch the code to stop calling INSTALL(DIRECTORY ...) with a path that does not exist. Until CMake 3.1.0, this would end up creating an empty directory (hence the @dir entry in the plist). The behavior has changed in 3.1.0, and we were getting build errors because we were referring to a directory that did not exist in the plist.
|
@giox069 the two include files are indeed needed for plugin development. I'm for the merge, no side effects and included files are really needed for thirdy part plugin development. |
muflone
added a commit
that referenced
this pull request
Jan 2, 2015
remmina: Actually install its headers.
|
Committed on both master and next branches, thank you @rakuco |
jbicha
pushed a commit
to jbicha/Remmina
that referenced
this pull request
Jun 12, 2016
remmina: Actually install its headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation of the headers in
remmina/include/remminahas beenbroken ever since Remmina moved away from autotools, as the path
specified in the call to
install()did not exist.Move the
install()call to remmina/ so that it works, and add a trailing/ to the path so that we do not end up with
$CMAKE_INSTALL_PREFIX/include/remmina/remmina.