Mark mutex as robust to prevent deadlocks #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent application hangs that occur when a thread dies while holding a mutex, particularly during vTaskEndScheduler or exit calls. This is achieved by setting the PTHREAD_MUTEX_ROBUST attribute on the mutex. Fixes: - GitHub issue: FreeRTOS#1217 - Forum thread: freertos.org/t/22287 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 91.64% 91.53% -0.11%
==========================================
Files 6 6
Lines 3254 3260 +6
Branches 903 901 -2
==========================================
+ Hits 2982 2984 +2
- Misses 132 135 +3
- Partials 140 141 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
|
Tested on my end. |
2 tasks
tony-josi-aws
approved these changes
Jan 27, 2025
archigup
approved these changes
Jan 27, 2025
n9wxu
approved these changes
Jan 28, 2025
|
2 tasks
johnboiles
reviewed
Jan 29, 2025
| @@ -46,23 +48,36 @@ struct event * event_create( void ) | |||
| if( ev != NULL ) | |||
| { | |||
| ev->event_triggered = false; | |||
| pthread_mutex_init( &ev->mutex, NULL ); | |||
| pthread_mutexattr_init( &ev->mutexattr ); | |||
| #ifndef __APPLE__ | |||
There was a problem hiding this comment.
I wonder how we can get similar benefits on macOS/iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent application hangs that occur when a thread dies while holding a mutex, particularly during vTaskEndScheduler or exit calls. This is achieved by setting the PTHREAD_MUTEX_ROBUST attribute on the mutex.
Test Steps
Tested locally using the modified application as suggested in this thread. Was also tested by @denravonska.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.