fix: block when below trigger level #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream buffers appear to only block when the buffer is empty, which doesn't seem to help anybody... This will force the current task to block until the trigger level has been reached
|
@RichardBarry Any thoughts on this? Maybe this should be enabled through a config to allow users to specify whether or not they want to block if the trigger level hasn't been reached. |
Closed
|
@cperkulator Lets continue the discussion here - #643 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream buffers appear to only block when the buffer is empty, which doesn't seem to help anybody... This will force the current task to block until the trigger level has been reached
Description
This allows the stream buffer to block when the amount of data in a stream buffer is less than the trigger level.
Test Steps
Reference issue below.
Checklist:
I have tested my changes. No regression in existing tests.
I have modified and/or added unit-tests to cover the code changes in this Pull Request.
We have tested the stream buffer works as we expect. We have not ran existing tests to confirm no regressions have been made.
We have not added any unit tests.
Related Issue
#643
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.