Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xHigherPriorityTaskWoken #1215

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented Dec 24, 2024

Description

This causes failure because of this innocuous looking change - FreeRTOS/FreeRTOS-Kernel#1207.

Test Steps

Run MQTT Plain Text Demo and TCP Demo with libslirp.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • [NA] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

FreeRTOS/FreeRTOS-Kernel#1207

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The thread context should use non-ISR version.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg requested a review from a team as a code owner December 24, 2024 10:19
Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

portYIELD_FROM_ISR() does nothing in the port which use the libslirp network interface. It looks okay to me to remove it in the implementation.
FreeRTOS/FreeRTOS-Kernel#1207

@aggarg aggarg merged commit fbb668a into FreeRTOS:main Dec 24, 2024
10 checks passed
@aggarg aggarg deleted the libslirp_nw_interface branch December 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants