Add possibility to redefine SD detection pin irq handlers at application level #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallenbach
force-pushed
the
add-possibility-to-redefine-irq-handlers-at-application-level
branch
from
f56bed0 to
5e1cac1
Compare
aggarg
reviewed
May 21, 2025
include/FreeRTOSFATConfigDefaults.h
Outdated
| @@ -521,4 +521,10 @@ | |||
| #define FF_CreateIOManger FF_CreateIOManager | |||
| #endif /* ffconfigENABLE_BACKWARD_COMPATIBILITY */ | |||
|
|
|||
| #ifndef ffconfigSDIO_DRIVER_DEFINES_SD_DETECTION_INTERRUPT_HANDLER | |||
There was a problem hiding this comment.
Since this macro applies to 2 STM32 ports only, pleas move the default value to ff_sddisk.c files for those ports.
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
approved these changes
May 22, 2025
kar-rahul-aws
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration macro to allow interrupt handlers related to SD detection pin to be deactivated at compile time without changing the source code.
Description
The way STM32F4xx and STM32F7xx ports handle interrupts related to SD detection pin is a bit limiting for 2 reasons:
The idea here is to give the possibility to a user to handle this interrupt - if needed - at application level without changing the library source code. This PR introduces
ffconfigSDIO_DRIVER_DEFINES_SD_DETECTION_INTERRUPT_HANDLERmacro. There is also a modification applied to STM32F4xx and STM32F7xx ports to surroundHAL_GPIO_EXTI_CallbackandEXTI15_10_IRQHandlerwith this newly defined macro.FYI - related to this discussion on the forum.
Test Steps
Integrate the content of this PR in my project to check that functions can be defined at application level without conflicts.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.