Automate release with GitHub Action job #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leegeth
previously approved these changes
Dec 5, 2020
leegeth
previously approved these changes
Dec 7, 2020
leegeth
approved these changes
Dec 7, 2020
gkwicker
approved these changes
Dec 7, 2020
| @@ -163,7 +163,11 @@ typedef struct NetworkContext NetworkContext_t; | |||
| * @param[in] pBuffer Buffer to receive the data into. | |||
| * @param[in] bytesToRecv Number of bytes requested from the network. | |||
| * | |||
| * @return The number of bytes received or a negative error code. | |||
| * @return The number of bytes received or a negative value to indicate | |||
There was a problem hiding this comment.
Is this change mentioned in the commit message?
There was a problem hiding this comment.
Nope, but this change was just to satisfy the SSoT CI check between transport_interface.h files of coreMQTT and coreHTTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub Action job to trigger a release process which includes operations of:
The workflow can be manually triggered and takes the input values of Commit ID (to create a release for) and the Version string for tagging the release with
Testing
Here is an example run of the release job on my fork repository:
https://github.com/aggarw13/coreHTTP/runs/1512507665?check_suite_focus=true
It pushed the test tag (
test-v2) and created a release along with the release asset on the repository: https://github.com/aggarw13/coreHTTP/releases/tag/test-v3