CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE #25

brothercorvo · 2023-01-01T14:03:31Z

No description provided.

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-06T21:06:34Z

digitalpy/core/component_management/component_management_facade.py

@@ -1,6 +1,6 @@
-from Catalog.Data.Domain.FTS_Model.Facade import Facade
+from digitalpy.core.component_management.impl.default_facade import DefaultFacade


[pep8] _{reported by reviewdog 🐶}
D100 Missing docstring in public module

naman108 · 2023-01-06T21:06:34Z

digitalpy/core/component_management/component_management_facade.py

@@ -1,6 +1,6 @@
-from Catalog.Data.Domain.FTS_Model.Facade import Facade
+from digitalpy.core.component_management.impl.default_facade import DefaultFacade


[pep8] _{reported by reviewdog 🐶}
I001 isort found an import in the wrong position

naman108 · 2023-01-06T21:06:34Z

digitalpy/core/component_management/component_management_facade.py

@@ -1,6 +1,6 @@
-from Catalog.Data.Domain.FTS_Model.Facade import Facade
+from digitalpy.core.component_management.impl.default_facade import DefaultFacade


[pep8] _{reported by reviewdog 🐶}
E501 line too long (81 > 79 characters)

naman108 · 2023-01-06T21:06:34Z

digitalpy/core/component_management/component_management_facade.py


-class ComponentManagementFacade(Facade, Facade):
+class ComponentManagementFacade(DefaultFacade):


[pep8] _{reported by reviewdog 🐶}
WPS230 Found too many public instance attributes: 8 > 6

naman108 · 2023-01-06T21:06:34Z

digitalpy/core/component_management/component_management_facade.py


-class ComponentManagementFacade(Facade, Facade):
+class ComponentManagementFacade(DefaultFacade):


[pep8] _{reported by reviewdog 🐶}
E302 expected 2 blank lines, found 1

naman108 · 2023-01-06T21:06:37Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        component = Component.from_dict(component_info)
+        self.component_registry.add_component(component)
+
+    def restart_component(self, component_id: str) -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

naman108 · 2023-01-06T21:06:37Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+    def restart_component(self, component_id: str) -> None:
+        component = self.component_registry.get_component(component_id)
+        if component is None:
+            raise ValueError(f"Component with ID {component_id} not found")


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-06T21:06:37Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+    def restart_component(self, component_id: str) -> None:
+        component = self.component_registry.get_component(component_id)
+        if component is None:
+            raise ValueError(f"Component with ID {component_id} not found")


[pep8] _{reported by reviewdog 🐶}
WPS305 Found f string

naman108 · 2023-01-06T21:06:37Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+            raise ValueError(f"Component with ID {component_id} not found")
+        component.restart()
+
+    def start_component(self, component_id: str) -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

naman108 · 2023-01-06T21:06:37Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+    def start_component(self, component_id: str) -> None:
+        component = self.component_registry.get_component(component_id)
+        if component is None:
+            raise ValueError(f"Component with ID {component_id} not found")


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-06T21:10:52Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+    def start_component(self, component_id: str) -> None:
+        component = self.component_registry.get_component(component_id)
+        if component is None:
+            raise ValueError(f"Component with ID {component_id} not found")


[pep8] _{reported by reviewdog 🐶}
WPS305 Found f string

naman108 · 2023-01-06T21:10:52Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+            raise ValueError(f"Component with ID {component_id} not found")
+        component.start()
+
+    def update_component(self, component_id: str, component_data: Dict[str, Any]):


[pep8] _{reported by reviewdog 🐶}
E501 line too long (82 > 79 characters)

naman108 · 2023-01-06T21:10:52Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        component.start()
+
+    def update_component(self, component_id: str, component_data: Dict[str, Any]):
+        """Updates the information of an existing component.


[pep8] _{reported by reviewdog 🐶}
D205 1 blank line required between summary line and description

naman108 · 2023-01-06T21:10:52Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        component.start()
+
+    def update_component(self, component_id: str, component_data: Dict[str, Any]):
+        """Updates the information of an existing component.


[pep8] _{reported by reviewdog 🐶}
D401 First line should be in imperative mood

naman108 · 2023-01-06T21:10:52Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        component.start()
+
+    def update_component(self, component_id: str, component_data: Dict[str, Any]):
+        """Updates the information of an existing component.


[pep8] _{reported by reviewdog 🐶}
DAR101 Missing parameter(s) in Docstring: - component_data

naman108 · 2023-01-06T21:10:55Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        """Stops a specific component"""
+        pass
+
+    def restart_component(self):


[pep8] _{reported by reviewdog 🐶}
F811 redefinition of unused 'restart_component' from line 32

naman108 · 2023-01-06T21:10:55Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        """Stops a specific component"""
+        pass
+
+    def restart_component(self):


[pep8] _{reported by reviewdog 🐶}
WPS440 Found block variables overlap: restart_component

naman108 · 2023-01-06T21:10:55Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        pass
+
+    def restart_component(self):
+        """Restarts a specific component"""


[pep8] _{reported by reviewdog 🐶}
D400 First line should end with a period

naman108 · 2023-01-06T21:10:55Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+
+    def restart_component(self):
+        """Restarts a specific component"""
+        pass


[pep8] _{reported by reviewdog 🐶}
WPS420 Found wrong keyword: pass

naman108 · 2023-01-06T21:10:56Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        pass
+
+    def component_discovery(self):
+        """discover all the installed components"""


[pep8] _{reported by reviewdog 🐶}
D400 First line should end with a period

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-06T21:15:15Z

digitalpy/core/domain/node.py

@@ -1017,4 +1017,4 @@ def set_value(
            return result

        # default behaviour
-        return super().set_value(name, value, force_set, track_change)
+        return super().set_value(name, value, force_set, track_change)


[pep8] _{reported by reviewdog 🐶}
W292 no newline at end of file

naman108 · 2023-01-06T21:15:16Z

digitalpy/core/domain/object_id.py

@@ -137,4 +137,4 @@ def parse_oid_string(oid: str):

        prefix = ObjectId.DELIMITER + oid_parts

-        return {"type": type, "id": ids, "prefix": prefix}
+        return {"type": type, "id": ids, "prefix": prefix}


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-06T21:15:16Z

digitalpy/core/domain/object_id.py

@@ -137,4 +137,4 @@ def parse_oid_string(oid: str):

        prefix = ObjectId.DELIMITER + oid_parts

-        return {"type": type, "id": ids, "prefix": prefix}
+        return {"type": type, "id": ids, "prefix": prefix}


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-06T21:15:16Z

digitalpy/core/domain/object_id.py

@@ -137,4 +137,4 @@ def parse_oid_string(oid: str):

        prefix = ObjectId.DELIMITER + oid_parts

-        return {"type": type, "id": ids, "prefix": prefix}
+        return {"type": type, "id": ids, "prefix": prefix}


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-06T21:15:16Z

digitalpy/core/domain/object_id.py

@@ -137,4 +137,4 @@ def parse_oid_string(oid: str):

        prefix = ObjectId.DELIMITER + oid_parts

-        return {"type": type, "id": ids, "prefix": prefix}
+        return {"type": type, "id": ids, "prefix": prefix}


[pep8] _{reported by reviewdog 🐶}
W292 no newline at end of file

naman108 · 2023-01-06T21:15:18Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        """Retrieves information about a specific component"""
+        pass
+
+    def update_component(self):


[pep8] _{reported by reviewdog 🐶}
WPS440 Found block variables overlap: update_component

naman108 · 2023-01-06T21:15:19Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        pass
+
+    def update_component(self):
+        """Updates the information of an existing component"""


[pep8] _{reported by reviewdog 🐶}
D400 First line should end with a period

naman108 · 2023-01-06T21:15:19Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+        pass
+
+    def update_component(self):
+        """Updates the information of an existing component"""


[pep8] _{reported by reviewdog 🐶}
D401 First line should be in imperative mood

naman108 · 2023-01-06T21:15:19Z

digitalpy/core/component_management/controllers/component_management_general_controller.py

+
+    def update_component(self):
+        """Updates the information of an existing component"""
+        pass


[pep8] _{reported by reviewdog 🐶}
WPS420 Found wrong keyword: pass

naman108 · 2023-01-06T21:15:19Z

digitalpy/core/component_management/controllers/component_management_controller.py

@@ -7,21 +7,22 @@
 # Original author: Giu Platania
 # 
 #######################################################
-from Catalog.Implementation.Libraries.Digitalpy.digitalpy.Async.logic.impl.default_business_rule_controller import DefaultBusinessRuleController
+from digitalpy.core.logic.impl.default_business_rule_controller import DefaultBusinessRuleController


[pep8] _{reported by reviewdog 🐶}
I001 isort found an import in the wrong position

CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE

08fcdc5

brothercorvo requested a review from naman108 January 1, 2023 14:04

brothercorvo added this to the 2.0 milestone Jan 1, 2023

Giu Platania and others added 3 commits January 3, 2023 09:37

deleted FTS Core packages

91313f8

fixed syntax bugs and added/improved docs

7813ad0

Merge branch 'main' into Optimization

0cdfb40

naman108 reviewed Jan 6, 2023

View reviewed changes

Merge branch 'main' into Optimization

c7d35e1

naman108 reviewed Jan 6, 2023

View reviewed changes

added removed files back into domain

2b0cc5b

naman108 reviewed Jan 6, 2023

View reviewed changes

naman108 approved these changes Jan 6, 2023

View reviewed changes

naman108 merged commit be9bf96 into main Jan 6, 2023

naman108 deleted the Optimization branch January 6, 2023 21:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE #25

CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE #25

brothercorvo commented Jan 1, 2023

naman108 left a comment

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 left a comment

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 left a comment

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

naman108 Jan 6, 2023

		@@ -1,6 +1,6 @@
		from Catalog.Data.Domain.FTS_Model.Facade import Facade
		from digitalpy.core.component_management.impl.default_facade import DefaultFacade


		class ComponentManagementFacade(Facade, Facade):
		class ComponentManagementFacade(DefaultFacade):

CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE #25

CREATED NEW CONTROLLERS, OPTIMIZED EXISTING CODE #25

Conversation

brothercorvo commented Jan 1, 2023

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment