Service support #26

brothercorvo · 2023-01-01T14:17:39Z

added service support to digitalpy

…sues

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-01T14:18:53Z

digitalpy/core/main/state_change_event.py

@@ -9,7 +9,7 @@
 #######################################################
 from typing import Any
 from digitalpy.core.persistence.persistent_object import PersistentObject
-from digitalpy.core.event import Event
+from digitalpy.core.main.event import Event


[pep8] _{reported by reviewdog 🐶}
I001 isort found an import in the wrong position

naman108 · 2023-01-01T14:18:53Z

digitalpy/core/zmanager/integration_manager.py

@@ -11,33 +11,50 @@
 import zmq

 class IntegrationManager:
+    def __init__(self, integration_manager_puller_protocol: str, integration_manager_puller_address: str, integration_manager_puller_port: int,


[pep8] _{reported by reviewdog 🐶}
D107 Missing docstring in init

naman108 · 2023-01-01T14:18:53Z

digitalpy/core/zmanager/integration_manager.py

@@ -11,33 +11,50 @@
 import zmq

 class IntegrationManager:
+    def __init__(self, integration_manager_puller_protocol: str, integration_manager_puller_address: str, integration_manager_puller_port: int,


[pep8] _{reported by reviewdog 🐶}
WPS317 Found incorrect multi-line parameters

naman108 · 2023-01-01T14:18:54Z

digitalpy/core/zmanager/integration_manager.py

@@ -11,33 +11,50 @@
 import zmq

 class IntegrationManager:
+    def __init__(self, integration_manager_puller_protocol: str, integration_manager_puller_address: str, integration_manager_puller_port: int,


[pep8] _{reported by reviewdog 🐶}
WPS211 Found too many arguments: 7 > 5

naman108 · 2023-01-01T14:18:54Z

digitalpy/core/zmanager/integration_manager.py

@@ -11,33 +11,50 @@
 import zmq

 class IntegrationManager:
+    def __init__(self, integration_manager_puller_protocol: str, integration_manager_puller_address: str, integration_manager_puller_port: int,


[pep8] _{reported by reviewdog 🐶}
E501 line too long (143 > 79 characters)

naman108 · 2023-01-01T14:18:56Z

digitalpy/core/zmanager/integration_manager.py

+                # receive a message from a client
+                request = self.pull_socket.recv_multipart()[0]
+                response_protocol, response_object_unserialized = request.split(b',', 1)
+                subject = b"/messages" + response_protocol


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-01T14:18:56Z

digitalpy/core/zmanager/integration_manager.py

+                # receive a message from a client
+                request = self.pull_socket.recv_multipart()[0]
+                response_protocol, response_object_unserialized = request.split(b',', 1)
+                subject = b"/messages" + response_protocol


[pep8] _{reported by reviewdog 🐶}
WPS336 Found explicit string concatenation

naman108 · 2023-01-01T14:18:56Z

digitalpy/core/zmanager/integration_manager.py

+                response_protocol, response_object_unserialized = request.split(b',', 1)
+                subject = b"/messages" + response_protocol
+
+                try:


[pep8] _{reported by reviewdog 🐶}
WPS505 Found nested try block

naman108 · 2023-01-01T14:18:56Z

digitalpy/core/zmanager/integration_manager.py

+
+                try:
+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-01T14:18:56Z

digitalpy/core/zmanager/integration_manager.py

+
+                try:
+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)


[pep8] _{reported by reviewdog 🐶}
WPS336 Found explicit string concatenation

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-03T16:50:18Z

setup.py

@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages

 setup(name='digitalpy',
-      version='0.2.6.1',
+      version='0.2.6.3',


[pep8] _{reported by reviewdog 🐶}
WPS318 Found extra indentation

naman108 · 2023-01-03T16:50:18Z

digitalpy/core/zmanager/integration_manager.py

+
+                try:
+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)


[pep8] _{reported by reviewdog 🐶}
E501 line too long (87 > 79 characters)

naman108 · 2023-01-03T16:50:18Z

digitalpy/core/zmanager/integration_manager.py

+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)
+                except Exception as ex:
+                    print("Error sending response to client: {}".format(ex))


[pep8] _{reported by reviewdog 🐶}
WPS421 Found wrong function call: print

naman108 · 2023-01-03T16:50:18Z

digitalpy/core/zmanager/integration_manager.py

+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)
+                except Exception as ex:
+                    print("Error sending response to client: {}".format(ex))


[pep8] _{reported by reviewdog 🐶}
P101 format string does contain unindexed parameters

naman108 · 2023-01-03T16:50:19Z

digitalpy/core/zmanager/integration_manager.py

+                    # send the response back to the client
+                    self.pub_socket.send(subject + b" " + response_object_unserialized)
+                except Exception as ex:
+                    print("Error sending response to client: {}".format(ex))


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-03T16:50:22Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

naman108 · 2023-01-03T16:50:22Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):
+        self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-03T16:50:22Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):
+        self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))


[pep8] _{reported by reviewdog 🐶}
WPS336 Found explicit string concatenation

naman108 · 2023-01-03T16:50:22Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):
+        self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-03T16:50:22Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):
+        self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))


[pep8] _{reported by reviewdog 🐶}
E501 line too long (84 > 79 characters)

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

naman108 · 2023-01-03T16:50:37Z

setup.py

@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages

 setup(name='digitalpy',
-      version='0.2.6.1',
+      version='0.2.7',


[pep8] _{reported by reviewdog 🐶}
WPS318 Found extra indentation

naman108 · 2023-01-03T16:50:37Z

digitalpy/core/zmanager/impl/default_routing_worker.py


+    def send_error(self, exception: Exception):
+        self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))
+


[pep8] _{reported by reviewdog 🐶}
W293 blank line contains whitespace

naman108 · 2023-01-03T16:50:37Z

digitalpy/core/zmanager/impl/default_routing_worker.py


                response = ObjectFactory.get_new_instance("response")
                referrer = request.get_sender()
                context = request.get_context()
                action = request.get_action()
+                format = request.get_format()


[pep8] _{reported by reviewdog 🐶}
WPS125 Found builtin shadowing: format

naman108 · 2023-01-03T16:50:38Z

digitalpy/core/zmanager/impl/default_routing_worker.py

-                            "ActionKey undefined".encode("utf-8"),
-                        ]
+                    self.send_error(
+                        Exception(f"action key for action {request.get_action()} undefined")


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-03T16:50:38Z

digitalpy/core/zmanager/impl/default_routing_worker.py

-                            "ActionKey undefined".encode("utf-8"),
-                        ]
+                    self.send_error(
+                        Exception(f"action key for action {request.get_action()} undefined")


[pep8] _{reported by reviewdog 🐶}
WPS305 Found f string

naman108 · 2023-01-03T16:50:40Z

digitalpy/core/zmanager/impl/default_routing_worker.py

+            # Return the topic sections, response topic, and request
+            return response_topic, request
+        except Exception as ex:
+            self.send_error(ex)


[pep8] _{reported by reviewdog 🐶}
W292 no newline at end of file

naman108 · 2023-01-03T16:50:40Z

digitalpy/core/zmanager/impl/zeroless_pusher.py

+        push = self.pusher_client.push()
+        self.pusher_formatter.serialize(request)
+        push(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
WPS221 Found line with high Jones Complexity: 33 > 14

naman108 · 2023-01-03T16:50:40Z

digitalpy/core/zmanager/impl/zeroless_pusher.py

+        push = self.pusher_client.push()
+        self.pusher_formatter.serialize(request)
+        push(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-03T16:50:40Z

digitalpy/core/zmanager/impl/zeroless_pusher.py

+        push = self.pusher_client.push()
+        self.pusher_formatter.serialize(request)
+        push(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
E501 line too long (191 > 79 characters)

naman108 · 2023-01-03T16:50:40Z

digitalpy/core/zmanager/impl/zeroless_pusher.py

+        push = self.pusher_client.push()
+        self.pusher_formatter.serialize(request)
+        push(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
W292 no newline at end of file

…t and sock instantiation to occur after proccess start

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

digitalpy/core/zmanager/impl/zmq_pusher.py

naman108 · 2023-01-04T02:20:43Z

digitalpy/core/zmanager/impl/zmq_pusher.py

+        self.pusher_socket.connect(f"tcp://{address}:{port}")
+
+    def subject_send_request(self, request: Request, protocol: str):
+        """send the message to a Puller


[pep8] _{reported by reviewdog 🐶}
DAR101 Missing parameter(s) in Docstring: - protocol

naman108 · 2023-01-04T02:20:43Z

digitalpy/core/zmanager/impl/zmq_pusher.py

+        self.pusher_socket.connect(f"tcp://{address}:{port}")
+
+    def subject_send_request(self, request: Request, protocol: str):
+        """send the message to a Puller


[pep8] _{reported by reviewdog 🐶}
DAR101 Missing parameter(s) in Docstring: - request

naman108 · 2023-01-04T02:20:43Z

digitalpy/core/zmanager/impl/zmq_pusher.py

+        """send the message to a Puller
+        """
+        self.pusher_formatter.serialize(request)
+        self.pusher_socket.send(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
WPS221 Found line with high Jones Complexity: 35 > 14

naman108 · 2023-01-04T02:20:43Z

digitalpy/core/zmanager/impl/zmq_pusher.py

+        """send the message to a Puller
+        """
+        self.pusher_formatter.serialize(request)
+        self.pusher_socket.send(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
Q000 Double quotes found but single quotes preferred

naman108 · 2023-01-04T02:20:43Z

digitalpy/core/zmanager/impl/zmq_pusher.py

+        """send the message to a Puller
+        """
+        self.pusher_formatter.serialize(request)
+        self.pusher_socket.send(b",".join([request.get_sender().encode(), request.get_context().encode(), request.get_action().encode(), request.get_format().encode(), protocol.encode(), request.get_values()]))


[pep8] _{reported by reviewdog 🐶}
E501 line too long (210 > 79 characters)

naman108

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

digitalpy/core/telemetry/meter.py

digitalpy/core/zmanager/impl/default_routing_worker.py

naman108 added 3 commits December 31, 2022 17:06

updated pusher to use zmq instead of zeroless fixed seriallization is…

e4e2819

…sues

updated to support integration_manager

0037a9a

updated to support integration_manager

1e06e84

naman108 reviewed Jan 1, 2023

View reviewed changes

naman108 added 2 commits January 3, 2023 12:49

Update setup.py

7b71d0b

Update setup.py

0a89d21

naman108 reviewed Jan 3, 2023

View reviewed changes

updated to fix hanging socket connect error with zmq by moving contex…

84c6939

…t and sock instantiation to occur after proccess start

naman108 reviewed Jan 4, 2023

View reviewed changes

updated documentation

58fa340

naman108 reviewed Jan 6, 2023

View reviewed changes

naman108 marked this pull request as ready for review January 6, 2023 21:18

naman108 merged commit 848d3ae into main Jan 6, 2023

naman108 deleted the service-support branch January 6, 2023 21:22


		def send_error(self, exception: Exception):
		self.integration_manager_sock.send(b"error,"+str(exception).encode("utf-8"))

Service support #26

Service support #26

Conversation

brothercorvo commented Jan 1, 2023

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman108 left a comment

Choose a reason for hiding this comment