Update ft-subscribe-button profile dropdown to use profile id as key …

…& id, not index
FreeTubeApp · Oct 28, 2023 · 5b5c773 · 5b5c773
1 parent 9f8c95b
commit 5b5c773
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/renderer/components/ft-subscribe-button/ft-subscribe-button.js b/src/renderer/components/ft-subscribe-button/ft-subscribe-button.js
@@ -51,7 +51,7 @@ export default defineComponent({
       return this.$store.getters.getProfileList
     },
 
-    /* sort by 'All Channels' -> active profile -> unsubscribed channels -> unsubscribed channels */
+    /* sort by 'All Channels' -> active profile -> unsubscribed channels -> subscribed channels */
     profileDisplayList: function () {
       const mainProfileAndActiveProfile = [this.profileList[0]]
       if (this.activeProfile._id !== MAIN_PROFILE_ID) {

diff --git a/src/renderer/components/ft-subscribe-button/ft-subscribe-button.vue b/src/renderer/components/ft-subscribe-button/ft-subscribe-button.vue
@@ -42,13 +42,13 @@
         >
           <li
             v-for="(profile, index) in profileDisplayList"
-            :id="'profile-' + index"
-            :key="'subscription-profile-' + index"
+            :id="'subscription-profile-' + profile._id"
+            :key="profile._id"
             class="profile"
             :class="{
               subscribed: isProfileSubscribed(profile)
             }"
-            :aria-labelledby="'profile-' + index + '-name'"
+            :aria-labelledby="'subscription-profile-' + profile._id + '-name'"
             :aria-selected="isActiveProfile(profile)"
             :aria-checked="isProfileSubscribed(profile)"
             tabindex="0"
@@ -67,7 +67,7 @@
               </div>
             </div>
             <p
-              :id="'profile-' + index + '-name'"
+              :id="'subscription-profile-' + profile._id + '-name'"
               class="profileName"
             >
               {{ profile.name }}