Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent bahaviour of showing sponserblock segment color #1439

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jun 23, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Behavior of the program
Title says it all.

Expected behavior
Consistency in showing the color.

To Reproduce
See video.

Link to video

sW1D719Fwh.mp4

Screenshots
None.

Environment Information (please complete the following information):

  • OS: [Win 10]
  • OS Version: [20h2]
  • FreeTube version: [v0.13.1-nightly-937 Beta]
  • Installation Method (If applicable): [Portable]
  • Primary API Used: [Local API]

Additional context
None.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the bug Something isn't working label Jun 23, 2021
@GilgusMaximus
Copy link
Contributor

I would assume that the Sponsorblock data has to be loaded again and is not cached compared to the video and video data, so this is why it takes longer and is not included. But I would need the error output of the dev console to know more.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

it skips the sponser tho but it doesnt show the color. Knowing this would u still require output form the dev console?

@GurjinderSingh
Copy link

in some music videos non music part from Unpaid/Self Promotion or Interaction Reminder (Subscribe) not skipping.

watch?v=YgvDuXQeP_0

image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

i believe this is fixed by @MarmadileManteater because i cant reproduce it anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants