Feat: SponsorBlock improvements

[ChunkyProgrammer]

---

Sponsorblock improvements

Pull Request Type
Please select what type of pull request this is:

• Bugfix
• Feature Implementation

Related issue
closes #1840 (All categories implemented)
closes #1440 (User decides color for each category)
#1380 (Auto-skip is now optional, no prompt to skip however)

Description
This PR allows users to configure each SponsorBlock category individually (Color + Skip Mode)

Skip Modes:

• Don't Skip (No indication of sponsor will be shown in seek bar)
• Show In Seek Bar (Show the sponsored segment in the seek bar but don't autoskip)
• AutoSkip (AutoSkip when the video reaches the sponsored segment)

Mode not included (Might do a future PR to implement it):

• Prompt To Skip (Have a "Skip Sponsored Segment" button appear when a sponsored segment is reached)

Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Yes, tested by updating each category to make sure the setting works and loading a video with multiple categories involved

Desktop (please complete the following information):

• OS: Windows
• OS Version: 10
• FreeTube version: 0.15.0

[ChunkyProgrammer]

@efb4f5ff-1298-471a-8973-3d47447115dc do you think this should close #1440 ?

[PikachuEXE]

Constant definition code deduplicate oppotunity?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@efb4f5ff-1298-471a-8973-3d47447115dc do you think this should close #1440 ?

Oh yes definitely!

[efb4f5ff-1298-471a-8973-3d47447115dc]

The categories work for me, so if it detects a certain category it skips it but i never get to see the colors in the seek bar but maybe that is related to #1439

[ChunkyProgrammer]

The categories work for me, so if it detects a certain category it skips it but i never get to see the colors in the seek bar but maybe that is related to #1439

Is this color showing when not testing this PR?

[efb4f5ff-1298-471a-8973-3d47447115dc]

Nope its not showing for me on the latest nightly build.

[PikachuEXE]

Code Review cleared
But how do I test this locally?

[peepo5]

Hi, are these large settings titles still in this PR or have they been made smaller? In my opinion they should not be bold and should be around 3px smaller in size.

Another nitpick (not your fault but worthy of adding in this PR);
The enable toggle and notify toggle should be aligned by their button, not their center of text, for consistency. The enable toggle should also not have so much padding.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Do the colors show in your seek bar?

[ChunkyProgrammer]

Do the colors show in your seek bar?

Yes,

[ChunkyProgrammer]

Code Review cleared But how do I test this locally?

I'll try to get a list of videos for each category soon. To test it would basically be:

• Enable sponsor block
• individually enable categories
• go on a video and see seek bar populate with different colored markers (autoskips when autoskip enabled for category)

[efb4f5ff-1298-471a-8973-3d47447115dc]

I don't understand why it doesn't show the colors in the bar for me. I tried out a bunch of videos but none of them show any of the catagorie colors

[elesto]

Will you add Filler Tangent skip?

[ChunkyProgrammer]

Will you add Filler Tangent skip?

Was not aware of that category, I will add it

[elesto]

More features just released! https://blog.ajay.app/full-video-sponsorblock

[maxnordlund]

@PikachuEXE did you manage to test this locally? I would love to see this in an already amazing app. I want to know if there's sponsored content, but not automatically skip it, and this would allow for that (and more).

[PikachuEXE]

1. My last review comment already said I don't know how to test this
2. There are code conflicts

loading a video with multiple categories involved

At least I need the URL(s) for the video(s) 😅

[maxnordlund]

Here's a video with a few SponsorBlock segments: https://youtu.be/V_xFDsxPmNM

[PikachuEXE]

@maxnordlund
Thanks for helping!
Though I am still waiting for code conflict to be resolved...
Wait can I do it myself?

Edit: Resolved conflicts myself, force pushed

[efb4f5ff-1298-471a-8973-3d47447115dc]

today my machine finally let me review this properly.

This might be a problem. U cant see where u are in the video because the segmentcolor is blocking the seekbarcolor. U also cant know if it has buffered that part of the video.

VirtualBoxVM_g5qwJEe4sF.mp4

This is not related to this PR but the user doesn't get to see the notification in fullscreen and fullwindow

[ChunkyProgrammer]

today my machine finally let me review this properly.

This might be a problem. U cant see where u are in the video because the segmentcolor is blocking the seekbarcolor. U also cant know if it has buffered that part of the video.

Do you think making the indicators semi-transparent will solve the issue you have with the segmentcolor?

[efb4f5ff-1298-471a-8973-3d47447115dc]

today my machine finally let me review this properly.
This might be a problem. U cant see where u are in the video because the segmentcolor is blocking the seekbarcolor. U also cant know if it has buffered that part of the video.

Do you think making the indicators semi-transparent will solve the issue you have with the segmentcolor?

Yeah i think that making it semi transparent will solve the issue. Maybe making it only semi transparent when the user get at the segment. So before the segement and after it just stays a solid color and in the segment semi-transparent?

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM Thanks ChunkyWizard!

[PikachuEXE]

I think 0.6 would be a better value since 0.4 make it too dim... especially for yellow and green
(Also research linear gradient... not sure if possible or looks good)
Edit: linear gradient with rgba impossible as we have color values in names (e.g. blue), HEX values required...

0.6:

0.4:

0.8 looks like 1.0 lol

[PikachuEXE]

@absidue ~