Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint-plugin-vuejs-accessibility to linter rules #1580

Closed
kommunarr opened this issue Aug 12, 2021 · 3 comments · Fixed by #3863
Closed

Adding eslint-plugin-vuejs-accessibility to linter rules #1580

kommunarr opened this issue Aug 12, 2021 · 3 comments · Fixed by #3863
Labels
enhancement New feature or request

Comments

@kommunarr
Copy link
Collaborator

kommunarr commented Aug 12, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
Currently, FreeTube's linter has little to no rules necessitating basic accessible design. Without accessibility rules in place, devs unknowingly utilize harmful anti-patterns and push out features that disabled users cannot benefit from. Irregularly addressing these built-up accessibility issues all at once is an extremely comprehensive, daunting, and time-consuming task. Instituting thorough linter accessibility rules will help keep devs accountable for their own code, lower sum development time, and improve the overall code quality of FreeTube.

Describe the solution you'd like to see implemented
eslint-plugin-vuejs-accessibility is an open source eslint plugin whose gamut of accessibility rules will massively improve the accessibility & code quality of FreeTube.

I strongly recommend that all of the recommended accessibility rules from eslint-plugin-vuejs-accessibility be added to FreeTube's .eslintrc.js as such:

{
  "rules": {
    "vuejs-accessibility/rule-name": "error"
  }
}

For newly required changes to the existing project that cannot be automatically applied, I would be glad to implement them all concomitantly in #1525. Alternatively, a separate PR can be made if needed.

Describe alternatives you've considered

  1. [Less favorable] Implement most (but not all) of the accessibility rules. If there are certain pre-existing features that would require a difficult rework, implementing only most of the accessibility rules is a possible workaround (albeit not favorable).
  2. Use a different open source project's accessibility linter rules.

Additional context
I would categorize this as a relatively high priority. Every new PR that does not follow accessibility guidelines is more work needed down the line. This is increasingly unsustainable, and at some point the duty of basic accessibility needs to shift onto devs' own code.

@kommunarr kommunarr added the enhancement New feature or request label Aug 12, 2021
@kommunarr
Copy link
Collaborator Author

kommunarr commented Aug 13, 2021

#1525 now successfully adds eslint-plugin-vuejs-accessibility and implements its recommended linter rules. It also completely satisfies the new rules (as of 0e1f700). I know it is irksome to link one PR to two issues, but this seems to be the most convenient means to have the full project pass these accessibility rules. @PrestonN @GilgusMaximus Please let me know if this is acceptable.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants