Improve Accessibility of Profiles #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: dependencies
ChunkyProgrammer
requested review from
absidue,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
ChunkyProgrammer
commented
Aug 9, 2023
PikachuEXE
previously approved these changes
Aug 9, 2023
ChunkyProgrammer
commented
Aug 9, 2023
PikachuEXE
previously approved these changes
Aug 9, 2023
absidue
previously approved these changes
Aug 11, 2023
|
Everything works but i just wanted to mention this just to be sure So i dont know this for sure but im using the arrow keys here because i wanted to go down the list of profiles because i thought tabbing wasnt the right. Just like on the channel page with all the tabs that we changed recently that u only can tab to the first element of the list and the rest of the element u can reach by using arrow keys instead of tab. VirtualBoxVM_NYqFpwXA3y.mp4i was thinking the same here VirtualBoxVM_zzgWDwk6DQ.mp4 |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>
ChunkyProgrammer
dismissed stale reviews from absidue and PikachuEXE
via
9a13c33
ChunkyProgrammer
force-pushed
the
make-profiles-keyboard-accessible
branch
from
7870bb0 to
9a13c33
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
@efb4f5ff-1298-471a-8973-3d47447115dc The arrow keys are mainly used for tab navigation https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#keyboard_interaction |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 14, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
PikachuEXE
approved these changes
Aug 14, 2023
absidue
approved these changes
Aug 14, 2023
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 15, 2023
* feature/playlist-2023-05: (36 commits) ! Fix default playlists added when no playlist stored had no required attributes added on 1st run Translated using Weblate (Ukrainian) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Turkish) Translated using Weblate (Arabic) local API: Support Post Live DVR videos (FreeTubeApp#3872) Make profiles keyboard accessible (FreeTubeApp#3863) Bump @babel/preset-env from 7.22.9 to 7.22.10 (FreeTubeApp#3882) Bump @babel/eslint-parser from 7.22.9 to 7.22.10 (FreeTubeApp#3880) Bump eslint-plugin-vuejs-accessibility from 2.1.0 to 2.2.0 (FreeTubeApp#3883) Bump marked from 7.0.0 to 7.0.2 (FreeTubeApp#3881) Bump eslint-plugin-vue from 9.16.1 to 9.17.0 (FreeTubeApp#3879) Bump @babel/core from 7.22.9 to 7.22.10 (FreeTubeApp#3877) Bump stylelint-high-performance-animation from 1.8.0 to 1.9.0 (FreeTubeApp#3878) Bump sass from 1.64.2 to 1.65.1 (FreeTubeApp#3876) Bump eslint from 8.46.0 to 8.47.0 (FreeTubeApp#3875) Translated using Weblate (Italian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Accessibility of Profiles
Pull Request Type
Related issue
#693
closes #1580
Description
This PR gets FreeTube to be accessible enough for the eslint plugin to be enabled. There's still some changes needed to get stylelint to be enabled for our workflow.
Testing
Profile Selector
enterorspaceProfile Bubble
enterorspaceenterorspaceAll other changes are pretty small.
Desktop
Additional context