Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Section order #1739

Closed
1 of 5 tasks
ChunkyProgrammer opened this issue Sep 23, 2021 · 6 comments · Fixed by #5010
Closed
1 of 5 tasks

Settings Section order #1739

ChunkyProgrammer opened this issue Sep 23, 2021 · 6 comments · Fixed by #5010
Labels

Comments

@ChunkyProgrammer
Copy link
Member

Topic
Please select what topic your discussion is about.

  • Coding
  • Contribution
  • Languages
  • Setup
  • Other. Please specify: UI

Discussion
Please write down whatever you want to discuss.
I don't believe that the order that setting headers are presented in is optimal
Image

I feel like something like General then Theme then do the rest in alphabetical order would be better but the alphabetical order would change for different langauges so I don't think this would be ideal. Another option would be to save the order of the settings and allow user's to drag the headings to customize them. I think a more accessible and easier way to implement this would be to just add arrows going up or down to the headers when a button called "Customize Headers" is clicked. Thoughts?

@efb4f5ff-1298-471a-8973-3d47447115dc

Yeah i agree that sorting it alphabetically is not feasible. I do like the second suggestion tho. It would be really nice if the user can select where they want the setting to be.

@kommunarr
Copy link
Collaborator

kommunarr commented Sep 23, 2021

I haven't had a problem with this personally, but I do think this kind of permanent customization of list-like elements could be useful. Here are a few related issues: #1717 #987 #958 #17. Sorting by recency of use, sorting alphabetically, sorting manually, and "hiding" some selections seem to be all of the suggestions. If you did want to end up applying this capability to so many different kinds of lists (profiles, subscriptions, dropdown settings, app settings), you could add a button near them that would open a settings modal.

@efb4f5ff-1298-471a-8973-3d47447115dc

Still dont like the way its not ordered alphabetically tho. Looks like a big mess.

order a-z  primary theme color
order a-z  secondary theme color png
order a-z  trending region
order a-z app language

@efb4f5ff-1298-471a-8973-3d47447115dc

Not sure if it belongs here and wanted to open up an issue for this but i thought maybe i can ask it here. If u think this doesnt belong here and i should or should not open an issue about it pls let me know.

Hiding everything related to invidious when invidious is not selected as API. I mean there are people that dont even use that api and it maybe uses to much screen real estate. So why show me if im never ever going to do anything with it? Its just unnecessary in my opinion.
Screenshot (245)

Same here why show all of the related settings when its not even enabled?
Screenshot (246)

@kommunarr
Copy link
Collaborator

kommunarr commented Oct 16, 2021

@efb4f5ff-1298-471a-8973-3d47447115dc This is partially addressed in #1822. In particular, the Proxy Settings are now grayed when "Enable Tor/Proxy" is disabled. Are you still of the opinion that it should just disappear instead of being grayed out? Similarly, are you still of the opinion that "Current invidious instance" should disappear when "Fallback to Non-Preferred Backend on Failure" is set to false & Preferred API Backend is set to "Local API"? (This second case is not grayed out in #1822 at this time.)

My concern is that removing them instead of just graying them could cause confusion for people unfamiliar with that interaction who are looking for that functionality.

Edit: Added screenshots of such an implementation in #1822 & have it completed on my local branch.

@efb4f5ff-1298-471a-8973-3d47447115dc

As discussed in IRC, graying out will be just fine!

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added enhancement New feature or request and removed U: stale labels Jan 26, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 1, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 1, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 1, 2023
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 1, 2023
kommunarr added a commit to kommunarr/FreeTube that referenced this issue Apr 26, 2024
Solving the problem of preventing 'jumping around' when changing locales with alphabetical sorting is hard. This problem is easily solved by stickying general settings to the top of the list unconditionally. This is in line with ChunkyProgrammer's initial assessment of how to improve the settings order in FreeTubeApp#1739, albeit not also moving Theme Settings to the top for the time being. The rationale from a functional level is that General Settings is a hub. Even when you change languages, change sort order, or what have you, General Settings is right at the top. I don't imagine we need to update the label of the setting, as I think this relationship is quite intuitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants