Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: missing subtitle button #3095

Closed
3 of 5 tasks
ghost opened this issue Jan 20, 2023 · 3 comments · Fixed by #3100
Closed
3 of 5 tasks

[Bug]: missing subtitle button #3095

ghost opened this issue Jan 20, 2023 · 3 comments · Fixed by #3100
Labels
B: feature stopped working bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 20, 2023

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Most videos (for me, maybe language dependent or whatever) are missing the subtitle button now so they cannot be selected.
Example videos: 1, 2

Expected Behavior

Videos with subtitles should have a subtitle button so that they can be used again.

Issue Labels

feature stopped working

FreeTube Version

v0.18.0-nightly-2566

Operating System Version

Windows 11 22H2

Installation Method

Portable

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.18.0-nightly-2514

Additional Information

Same as this closed (without fixing) issue #3071.

Nightly Build

@ghost ghost added the bug Something isn't working label Jan 20, 2023
@absidue
Copy link
Member

absidue commented Jan 20, 2023

What language have you set FreeTube to use? The subtitles button shows up on both videos for me with FreeTube set to English (US) and English (UK).

@ghost
Copy link
Author

ghost commented Jan 20, 2023

Korean, lol.

edit: I hope you got that was a joke. If one suspects a language problem and knows english works fine why would one even bother trying English (US) and English (UK)? I tried all 55 languages and System Default and there are only 3 that work, guess which?

@absidue
Copy link
Member

absidue commented Jan 21, 2023

Thanks for trying out all of the languages, it would have been quicker to open the devtools and take a screenshot of the error, although I forget sometimes that not everyone knows about the devtools.

Turns out it was a simple typo languageCode instead of language_code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant