Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App starts in fullscreen if you used fullscreen before quitting #4534

Open
5 of 6 tasks
mooreye opened this issue Jan 8, 2024 · 24 comments · May be fixed by #5138
Open
5 of 6 tasks

[Bug]: App starts in fullscreen if you used fullscreen before quitting #4534

mooreye opened this issue Jan 8, 2024 · 24 comments · May be fixed by #5138
Labels
B: accessibility bug Something isn't working

Comments

@mooreye
Copy link

mooreye commented Jan 8, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Watch any video in fullscreen
  2. Quit the app with ctrl+Q or just closing the window but without quitting from fullscreen first.
  3. run app again
  4. it will start in fullscreen

Expected Behavior

app resets to non-fullscreen on start

Issue Labels

accessibility issue

FreeTube Version

v0.19.1 Beta

Operating System Version

fedora 39

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@mooreye mooreye added the bug Something isn't working label Jan 8, 2024
@poltpolt
Copy link

I confirm on steam deck and opensuse

@kommunarr
Copy link
Collaborator

This is an interesting byproduct of this feature being implemented. Don't see an easy fix on this one without altering this feature.

@absidue
Copy link
Member

absidue commented Jan 14, 2024

We would need some way of determining during shutdown, whether the user entered full screen in the player or already before that. As there are definitely valid uses cases for having the app remembering it's full screen (e.g media centre PCs, when you full screen an app on macOS it gets moved to a separate workspace, so you can still switch back to other windows), but I can completely understand you don't want FreeTube starting in full screen if you only did it to watch a video in full screen.

@poltpolt
Copy link

poltpolt commented Jan 15, 2024

on steam deck with no physical keyboard/mouse the only dirty tricky to switch to other windows or even exit is clicking the links in "About" to get firefox open. Otherwise you are stuck with touchscreen, unable to minimise or close.
~2Million steam decks running worldwide

maybe a button for both close and minimise somewhere?

@xypage
Copy link

xypage commented Feb 6, 2024

This is an interesting byproduct of this feature being implemented. Don't see an easy fix on this one without altering this feature.

Could we just add an option to disable that entirely then? I imagine most people (me included) don't use full screen while navigating, so there would be no need to remember state since it's something for videos and not the surrounding UI. Maybe an option to default to windowed, full screen, or last used?

@lothar-cell
Copy link

I actually asked for this feature specifically:D #1535
I always use the app in fullscreed and navigate between spaces with gestures. For example Apple Mail and Spotify have this feature built-in, because it is really annoying to press the fullscreen button every time when starting up the app.

@poltpolt
Copy link

I actually asked for this feature specifically:D #1535 I always use the app in fullscreed and navigate between spaces with gestures. For example Apple Mail and Spotify have this feature built-in, because it is really annoying to press the fullscreen button every time when starting up the app.

valid point but you have to have an option to quit or minimise the app to regular size - with touchscreen only , there is no way to do it.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@2Shot0ccurence
Copy link

For me this problem is actually persistent after a full reinstall.

@Victor239
Copy link

Is this an irreversible change? I accidentally closed once whilst fullscreen and now it's forever opening in fullscreen.

@absidue
Copy link
Member

absidue commented Mar 22, 2024

@Victor239 Press F11 to exit full screen, close FreeTube and when you reopen it, it should open normally again.

@Victor239
Copy link

Thanks! I was disabling fullscreen by through right-clicking the app in my Task Manager (KDE) and unchecking the fullscreen box which didn't change things for next launch, pressing F11 instead worked.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@poltpolt
Copy link

pressing F11 is not really a solution on keyboardless setups like steamdeck, that is why a button in gui would be appreciated.

@absidue
Copy link
Member

absidue commented Apr 22, 2024

@poltpolt Pressing F11 was never meant to be a solution, it's a workaround, adding extra buttons that are pointless for most of FreeTube's users, is just another workaround.

If you have a suggestion for an actual solution, please mention it, but repeating the same thing again and again, that isn't a solution, helps nobody.

@poltpolt
Copy link

poltpolt commented Apr 22, 2024

@absidue I think you underestimate the number of Steamdeck+FreeTube users

@absidue absidue linked a pull request May 20, 2024 that will close this issue
1 task
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@4-FLOSS-Free-Libre-Open-Source-Software

I do like to start the app in fullscreen always. How to make sure?

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: accessibility bug Something isn't working
Projects
Status: To assign
10 participants