Implement last window's fullscreen state #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc,
absidue and
ChunkyProgrammer
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
src/datastores/handlers/base.js
Outdated
| @@ -34,6 +34,14 @@ class Settings { | |||
| static _updateBounds(value) { | |||
| return db.settings.update({ _id: 'bounds' }, { _id: 'bounds', value }, { upsert: true }) | |||
| } | |||
|
|
|||
| static _findIsWindowFullscreen() { | |||
There was a problem hiding this comment.
Is this function used at all?
src/datastores/handlers/base.js
Outdated
| return db.settings.findOne({ _id: 'isWindowFullscreen' }) | ||
| } | ||
|
|
||
| static _updateIsWindowFullscreen(value) { |
There was a problem hiding this comment.
Is this function used at all?
PikachuEXE
force-pushed
the
feature/remember-fullscreen-state
branch
from
491f3b9 to
ec63b20
Compare
|
Unused methods removed |
absidue
approved these changes
Sep 19, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 19, 2022
|
@ChunkyProgrammer chunky power~ |
| @@ -255,7 +255,8 @@ function runApp() { | |||
|
|
|||
| const boundsDoc = await baseHandlers.settings._findBounds() | |||
| if (typeof boundsDoc?.value === 'object') { | |||
| const { maximized, ...bounds } = boundsDoc.value | |||
| console.log({ boundsDoc }) | |||
There was a problem hiding this comment.
Should probably remove the console.log
ChunkyProgrammer
approved these changes
Sep 20, 2022
github-actions
bot
removed
the
PR: waiting for review
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
closes #1535
Description
Implement last window's fullscreen state
Screenshots (if appropriate)
Lazy to take video
Testing (for code that is not small enough to be easily understandable)
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.