Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cmd+M on macOS mutes the video player instead of minimizing FreeTube #5828

Closed
5 of 6 tasks
OothecaPickle opened this issue Oct 6, 2024 · 1 comment · Fixed by #5829
Closed
5 of 6 tasks

[Bug]: Cmd+M on macOS mutes the video player instead of minimizing FreeTube #5828

OothecaPickle opened this issue Oct 6, 2024 · 1 comment · Fixed by #5829
Labels
B: keyboard control bug Something isn't working

Comments

@OothecaPickle
Copy link
Contributor

OothecaPickle commented Oct 6, 2024 •
edited by absidue
Loading

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Open a video.
  2. Press Cmd+M.
  3. This toggles mute instead of minimizing.

Expected Behavior

Cmd+M minimizes FreeTube while playing a video.

Issue Labels

keyboard control not working

FreeTube Version

056005d

Operating System Version

macOS Catalina 10.15.7

Installation Method

.dmg

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

This issue was introduced with FreeTube's switch to shaka-player

Nightly Build
@OothecaPickle OothecaPickle added the bug Something isn't working label Oct 6, 2024
@github-project-automation github-project-automation bot moved this to To assign in Bug Reports Oct 6, 2024
@PikachuEXE
Copy link
Collaborator

Can reproduce with MacOS 13.7

@jacopo-degattis jacopo-degattis mentioned this issue Oct 6, 2024
Merged
4 tasks
OothecaPickle pushed a commit to OothecaPickle/FreeTube that referenced this issue Oct 6, 2024
@jacopo-degattis @OothecaPickle
fix cmd+m shortcut to minimize the window on macos and not mute the v…
e282531 
…ideo (FreeTubeApp#5828)
OothecaPickle pushed a commit to OothecaPickle/FreeTube that referenced this issue Oct 6, 2024
@jacopo-degattis @OothecaPickle
fix cmd+m shortcut to minimize the window on macos and not mute the v…
dd2683a 
…ideo (FreeTubeApp#5828)
FreeTubeBot pushed a commit that referenced this issue Oct 7, 2024
@jacopo-degattis
fix cmd+m shortcut to minimize the window on macos and not mute the v…
7745a78 
…ideo (#5828) (#5829)
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this issue Oct 7, 2024
@PikachuEXE
Merge branch 'development' into feature/history/remember-search-query
707f950 
* development: (55 commits)
  Translated using Weblate (Russian)
  Translated using Weblate (Japanese)
  fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829)
  Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837)
  Bump the babel group with 4 updates (FreeTubeApp#5831)
  Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835)
  Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836)
  Bump the eslint group with 2 updates (FreeTubeApp#5832)
  Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833)
  Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Chinese (Traditional Han script))
  Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830)
  Translated using Weblate (Serbian)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Upgrade eslint 8 > 9 (FreeTubeApp#5777)
  Translated using Weblate (Belarusian)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this issue Oct 10, 2024
@PikachuEXE
Merge branch 'development' into feature/playlist-smart-merge
60a839f 
* development: (59 commits)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Enable Belarusian locale (FreeTubeApp#5841)
  Translated using Weblate (Russian)
  Translated using Weblate (Japanese)
  fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829)
  Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837)
  Bump the babel group with 4 updates (FreeTubeApp#5831)
  Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835)
  Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836)
  Bump the eslint group with 2 updates (FreeTubeApp#5832)
  Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833)
  Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Chinese (Traditional Han script))
  Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830)
  Translated using Weblate (Serbian)
  Translated using Weblate (Belarusian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B: keyboard control bug Something isn't working
Projects
Bug Reports
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix cmd+m shortcut to minimize the window on macos and not mute the video jacopo-degattis/FreeTube
2 participants
@PikachuEXE @OothecaPickle