* Update all GH workflow config to update node 14.x > 16.x #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
ChunkyProgrammer,
PrestonN,
efb4f5ff-1298-471a-8973-3d47447115dc,
kommunarr and
peepo5
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 17, 2021
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
PikachuEXE
requested review from
ChunkyProgrammer,
PrestonN,
kommunarr and
peepo5
and removed request for
PrestonN,
peepo5,
ChunkyProgrammer and
kommunarr
|
Weren't there problems with node 16? Or am I just imagining things |
|
What problems? |
Only thing I can think of is package-lock conflicts (we're not using package-lock anymore and 16 is the currently active version so I think this change is reasonable) |
ChunkyProgrammer
approved these changes
Nov 26, 2021
|
Another reason for using 16 |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: dependencies
1 task
|
There are issues on node 17 (we need to use a newer webpack version to fix it AFAIK), 16 is fine though. |
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
removed request for
PrestonN,
kommunarr and
peepo5
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PrestonN,
Svallinn,
Hiers,
GilgusMaximus and
kommunarr
and removed request for
Hiers
PrestonN
approved these changes
May 10, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
N/A
Description
Update all GH Action config to use Node 16.x instead of 14.x
16.x is the latest LTS version now
Screenshots (if appropriate)
N/A
Testing (for code that is not small enough to be easily understandable)
No testing done...
Well I am using Node 16.x locally for running FT in dev
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.