Switch debug and picture in picture shortcuts for consistency #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I'll allow this change. Before I merge however, could you please make a PR at the Docs Repo updating the page with the updated shortcuts? Once that is made then I will merge both PRs. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
|
both dont work for me? d doesnt open debug |
Did you test this on development branch? Does I open debug for you there? Does D open picture in picture? I just switched them around hah |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Mar 22, 2022
ChunkyProgrammer
previously approved these changes
Mar 23, 2022
Good point I think it doesn't hurt :) I'll add it. |
auto-merge was automatically disabled
March 23, 2022 14:10
Head branch was pushed to by a user without write access
vallode
dismissed stale reviews from ChunkyProgrammer and efb4f5ff-1298-471a-8973-3d47447115dc
via
0ab210f
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 23, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch debug and picture in picture shortcuts for consistency
Pull Request Type
Related issue
Partially addresses #2138
Description
Switches the PiP shortcut (d) with the debug shortcut (i) for consistency with Youtube's own shortcuts. See the related issue.
Desktop (please complete the following information):