Fix #1774 - Dropdown doesn't match theme in dark mode #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Apr 15, 2022
There was a problem hiding this comment.
- Its almost invisible in the black theme
- in the dark theme the items in the list dont get highlighted anymore
on another note: dont just ignore the template. u can just remove headers that are unnecessary to you and fill in the other parts. See example
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
April 15, 2022 16:51
Pull request was converted to draft
I fixed the highlight in dark theme, but I don't know how should i fix the invisible problem in black theme. The way I proposed is to change the |
|
Sure, we could definitely give that a try |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 16, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer and
PikachuEXE
PikachuEXE
changed the title
PikachuEXE
approved these changes
May 13, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix playlist dropdown menu theme not match
Pull Request Type
Related issue
Closes #1774
Description
Screenshots (if appropriate)
Desktop