channel fix (banner, playlist) #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
auto-merge was automatically disabled
April 23, 2022 16:02
Head branch was pushed to by a user without write access
|
Removed wonder why getPlaylistsLocal has it but invidious doesn't |
|
@hockerschwan probably because the Invidious API stays mostly the same and when it does change the changes are usually not breaking, however due to the nature of the local API using libraries that scrape the YouTube website the likelyhood of the output changing is much higher. |
|
Thanks for the explanation. |
ChunkyProgrammer
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
PikachuEXE
approved these changes
May 12, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 12, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
Closes #2214
Description
Banner: Invidious returns "authorBanners": [ ] for channels without banners, results in "TypeError: Cannot read properties of undefined (reading 'url')"
example: UC3VHfy8e1jbDnT5TG2pjP1w (Nyan cat)
Playlist:
Screenshots (if appropriate)
Shows defaultBanner.png
Testing (for code that is not small enough to be easily understandable)
Visit a channel without banner
Desktop (please complete the following information):