Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even spacing on top-nav #2280

Merged

Conversation

vallode
Copy link
Contributor

@vallode vallode commented May 31, 2022


Even spacing on top-nav

Pull Request Type
Please select what type of pull request this is:

  • Bugfix

Description
Tiny adjustments to the top-nav

  • Even spacing for all action buttons on left side
  • Hover indicator for profile button
  • Profile button is matched in width/height to the rest of the buttons for visual consistency

Screenshots (if appropriate)
The changes are pretty subtle, they don't really show well on screenshots.

Testing (for code that is not small enough to be easily understandable)
Simulated smaller screens and just had a general look around profile sections to see if anything is amiss!

Desktop (please complete the following information):

  • OS: [e.g. iOS] 10
  • OS Version: [e.g. 22] Debian
  • FreeTube version: [e.g. 0.8] upstream/development

@PrestonN PrestonN enabled auto-merge (squash) May 31, 2022 10:51
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrestonN PrestonN merged commit 989f37f into FreeTubeApp:development Jun 1, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 1, 2022
@vallode
Copy link
Contributor Author

vallode commented Jun 1, 2022

I am so outdated on how to use flex...

* https://developer.mozilla.org/en-US/docs/Web/CSS/gap

* https://coryrylan.com/blog/css-gap-space-with-flexbox

* https://css-tricks.com/almanac/properties/g/gap/

In general the CSS stack here is fairly outdated, I try to touch on it wherever I can but I also understand drastically changing it undermines the ability of everyone to maintain it. Let me know if I am overstepping with some of the changes I make!

@vallode vallode deleted the feature/top-nav-improvements branch June 1, 2022 09:05
@PikachuEXE
Copy link
Collaborator

Use new stuff is necessary
I just don't have the chance to use new stuff lol
(and flexbox is not really "new" anyway...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants