Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installation method and API method mandatory in bug issue template #2342

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 20, 2022


Make installation method and API method mandatory in bug issue template

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation
  • IRC discussion? :)

Description
In the past people neglected to mention in an API related issue, what API they were using or installation method they were using in a installation they used that broke FT.

This was because the fields were not mandatory.

Additional context
I need some help on deciding what to do with the position of the API field. I would like to see all the mandatory fields first but i dont know what position sounds logical to move the API field to. Also im feeling a bit conflicted about changing the position because of the already logical order of all the fields.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 20, 2022
@PrestonN PrestonN enabled auto-merge (squash) June 20, 2022 15:32
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

@absidue what is your opinion on the API position?

@absidue
Copy link
Member

absidue commented Jun 20, 2022

I guess you could swap it with the one above it, that would keep them in a faily logical order.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

fixed

@PrestonN PrestonN merged commit fe84889 into development Jun 21, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 21, 2022
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the update-bug-issue-template branch June 21, 2022 10:33
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jun 23, 2022
…uilds/build-more-versions

* commit '4f4f727ae1af304ce3131f03b29383ce4fdbb724': (104 commits)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Arabic)
  Translated using Weblate (Polish)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (French)
  Translated using Weblate (French)
  Translated using Weblate (Turkish)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Turkish)
  Translated using Weblate (French)
  Add Parental Controls (FreeTubeApp#1456)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Chinese (Simplified))
  Make installation method and API method mandatory in bug issue template (FreeTubeApp#2342)
  Fix removing the meta files when navigating to a new video (FreeTubeApp#2344)
  * Update app menu to add item for new window (FreeTubeApp#2306)
  Update electron-builder version to ^23.0.2 (FreeTubeApp#2305)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants