-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Catppuccin Mocha Theme #2395
Added Catppuccin Mocha Theme #2395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The theme is consistent across pages, the different colors look good.
Nothing is out of the expected and no unnecessary file is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! Only noticed that the text gets cut off but i dont know if we really want to address this.
VirtualBoxVM_jTjrHjK6kb.mp4
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a few theme colors and a few screens
Might even looks better than what I am using now oops
@efb4f5ff-1298-471a-8973-3d47447115dc I'm assuming they used the base (for dark) and text (for light) colors as defined by the official Mocha theme on this repo. I can easily replicate using the base and text colors for frappe and exporting from GIMP. |
@efb4f5ff-1298-471a-8973-3d47447115dc I did exactly what @dotunwrap said, I used gimp to change the colors according to Mocha official repo. |
Added Catppuccin Mocha Theme
Pull Request Type
Related issue
Closes: #2394
Description
This PR adds Catppuccin Mocha theme based on Catppuccin Mocha color palette by making the following changes:
/FreeTube/_icons
./FreeTube/src/main/index.js
./FreeTube/src/renderer/themes.css
..CatppuccinMocha
class to/FreeTube/src/renderer/components/ft-share-button/ft-share-button.sass
.'catppuccinMocha'
base theme value to/FreeTube/src/renderer/components/theme-settings/theme-settings.js
./FreeTube/src/renderer/store/modules/utils.js
./FreeTube/static/locales/en-US.yaml
.Screenshots
Testing:
Manually tested:
Desktop: