fix unsubscribe from "All Channels" profile #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
added
the
PR: waiting for review
PikachuEXE
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Tested locally with https://youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw
- Subscribe in 2 non default profiles
- Switch to default profile (all)
- Unsubscribe
- Switch to all profiles to confirm the channel unsubscribed
PikachuEXE
requested review from
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 15, 2022
absidue
approved these changes
Aug 16, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unsubscribe from "All Channels" profile
Important note
We may remove your pull request if you do not use this provided PR template correctly.
Pull Request Type
Please select what type of pull request this is:
Related issue
None.
Description
When on the "All Channels" profile, it should unsubscribe all channels from that channel. (It does this if you unsubscribe while on a channel's video but not from their Channel page)
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Subscribe to a channel on a few profiles, unsubscribe to the channel from the "Channel" page on the "All Channels" profile
Desktop (please complete the following information):
Additional context
I fixed this issue here #1934 as well but I don't have the time to fix up that PR