Fix channel page ID handling #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
reviewed
Aug 6, 2022
There was a problem hiding this comment.
Do we have a place to stored these "magic values"?
I certainly won't be able to parse all the constant values for idType in the future.
Not to mention I can't parse them now.
Edit 1: Something like this?
|
@PikachuEXE As those "magic values" come from yt-channel-info, if we create an enum it should definitely be in yt-channel-info and then imported into FreeTube. https://github.com/FreeTubeApp/yt-channel-info/blob/development/app/helper.js#L501 |
PikachuEXE
approved these changes
Aug 7, 2022
ChunkyProgrammer
approved these changes
Aug 8, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 8, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix channel page ID handling
Pull Request Type
Related issue
closes #2420
fixes a race condition introduced by #2259
Description
This pull request resolves two issues relating to the handling of channel IDs on the channel page.
/channel/,/user/and/c/channel URLs differently, as a/user/and/c/URLs with the same id might point to different channels.idproperty with the actual channel ID, so if you entered this URLhttps://www.youtube.com/c/linustechtips, theidproperty is set tolinustechtipsand when the info request returns it overwrites it with the channel IDUCXuqSBlHAE6Xw-yeJA0Tunw, as the videos and playlists functions still expect theidto belinustechtipsthey abort.The fix for this was to introduce an
originalIdproperty that is only updated when the actual channel changes, which is then used for the abort checks.Testing (for code that is not small enough to be easily understandable)
I tested the following URLs:
Desktop (please complete the following information):