Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization inconsistency fix for Local API #2535

Merged
merged 9 commits into from
Sep 9, 2022
Merged

Localization inconsistency fix for Local API #2535

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d3204a8
Applying a workaround for localization issue
MarmadileManteater Sep 3, 2022
f3f796a
Applying the same workaround on the description
MarmadileManteater Sep 3, 2022
17e3135
Added a fallback to videoDetails
MarmadileManteater Sep 3, 2022
2723aff
Adding a console error to the title try block
MarmadileManteater Sep 3, 2022
a2b58bc
Simplifying a loop to Array.join
MarmadileManteater Sep 3, 2022
26d07f8
Adding a console error to the description try block
MarmadileManteater Sep 3, 2022
2830b2a
Add a map for the description lines
MarmadileManteater Sep 3, 2022
be5826a
Added a question mark operator for descriptions
MarmadileManteater Sep 7, 2022
b9e595b
Each line already contains a `\n`
MarmadileManteater Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/renderer/views/Watch/Watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,14 @@ export default Vue.extend({

throw new Error(`${reason}: ${subReason}`)
}

this.videoTitle = result.videoDetails.title
try {
// workaround for title localization
this.videoTitle = result.response.contents.twoColumnWatchNextResults.results.results.contents[0].videoPrimaryInfoRenderer.title.runs[0].text
} catch (err) {
console.error('Failed to extract localised video title, falling back to the standard one.', err)
// if the workaround for localization fails, this sets the title to the potentially non-localized value
this.videoTitle = result.videoDetails.title
}
this.videoViewCount = parseInt(
result.player_response.videoDetails.viewCount,
10
Expand All @@ -299,7 +305,15 @@ export default Vue.extend({
})

this.videoPublished = new Date(result.videoDetails.publishDate.replace('-', '/')).getTime()
this.videoDescription = result.player_response.videoDetails.shortDescription
try {
// workaround for description localization
const descriptionLines = result.response.contents.twoColumnWatchNextResults.results.results.contents[1].videoSecondaryInfoRenderer.description?.runs
this.videoDescription = descriptionLines?.map(line => line.text).join('') ?? ''
} catch (err) {
console.error('Failed to extract localised video description, falling back to the standard one.', err)
// if the workaround for localization fails, this sets the description to the potentially non-localized value
this.videoDescription = result.player_response.videoDetails.shortDescription
}

switch (this.thumbnailPreference) {
case 'start':
Expand Down