Properly localize numbers

[ChunkyProgrammer]

---

Properly localize numbers

Pull Request Type
Please select what type of pull request this is:

• Bugfix

Related issue
closes #2547

Description
Number seperators (",", "." and " ") were not chosen based on locale and were always shown as ","

Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable)
Used search with different locales (had to clear search to test)

Desktop (please complete the following information):

• OS: Windows
• OS Version: 11
• FreeTube version: 0.17.1

[efb4f5ff-1298-471a-8973-3d47447115dc]

I saw this #853 issue from the same author. Is this harder to fix?

[ChunkyProgrammer]

I saw this #853 issue from the same author. Is this harder to fix?

I haven't really looked into that issue

[Aiz0]

While working on #2559 I noticed that 'en' will be used to format Like and Dislike numbers if no locale in freetube is set.
Should 'en' be replaced with 'default' so system locales format is used for this?

diff --git a/src/renderer/components/watch-video-info/watch-video-info.js b/src/renderer/components/watch-video-info/watch-video-info.js
index 4746dc55..6cc98007 100644
--- a/src/renderer/components/watch-video-info/watch-video-info.js
+++ b/src/renderer/components/watch-video-info/watch-video-info.js
@@ -219,7 +219,7 @@ export default Vue.extend({
       }
 
       const locale = this.currentLocale.replace('_', '-')
-      return this.likeCount.toLocaleString([locale, 'en'])
+      return this.likeCount.toLocaleString([locale, 'default'])
     },
 
     parsedDislikeCount: function () {
@@ -228,7 +228,7 @@ export default Vue.extend({
       }
 
       const locale = this.currentLocale.replace('_', '-')
-      return this.dislikeCount.toLocaleString([locale, 'en'])
+      return this.dislikeCount.toLocaleString([locale, 'default'])
     },
 
     likePercentageRatio: function () {

[ChunkyProgrammer]

While working on #2559 I noticed that 'en' will be used to format Like and Dislike numbers if no locale in freetube is set. Should 'en' be replaced with 'default' so system locales format is used for this?

diff --git a/src/renderer/components/watch-video-info/watch-video-info.js b/src/renderer/components/watch-video-info/watch-video-info.js
index 4746dc55..6cc98007 100644
--- a/src/renderer/components/watch-video-info/watch-video-info.js
+++ b/src/renderer/components/watch-video-info/watch-video-info.js
@@ -219,7 +219,7 @@ export default Vue.extend({
       }
 
       const locale = this.currentLocale.replace('_', '-')
-      return this.likeCount.toLocaleString([locale, 'en'])
+      return this.likeCount.toLocaleString([locale, 'default'])
     },
 
     parsedDislikeCount: function () {
@@ -228,7 +228,7 @@ export default Vue.extend({
       }
 
       const locale = this.currentLocale.replace('_', '-')
-      return this.dislikeCount.toLocaleString([locale, 'en'])
+      return this.dislikeCount.toLocaleString([locale, 'default'])
     },
 
     likePercentageRatio: function () {

Sounds like a good idea to me, maybe keep 'en' but move it after default?

[absidue]

@ChunkyProgrammer You shouldn't need to specify default here as you are getting the locale properly through i18n, so there will always be a locale set, the other PR doesn't currently do that.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Views says NaN?