Add setting to disable automatic fetching of subscription feed #2632

Aiz0 · 2022-09-28T00:02:58Z

Add setting to disable automatic fetching of subscription feed

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

closes #2515
part of #539

Description

Main changes

Adds a new setting in subscription settings to disable automatic fetching of the subscription feed.
Prevents calls to the method getSubscriptions() in Subscriptions.js in to places.

When the subscriptions component is mounted
In getProfileSubscriptions method, when the users switches profile.

When the users switches profile and has disabled auto fetching 2 things can happen

the video list is emptied.
if the video list is saved in profileSubscriptions then it will be loaded instead.

other stuff

In Subscriptions.vue I made some changes to the messages that show when the video list is empty

The regular "You have not subscribed to any channel" message will now only show when you have in fact not subscribed to any channel.
Added a new message that only shows if you have disabled automatic fetching.
Added a new message that will show when the user is subscribed to channels that have not uploaded any videos.

message 2 will block message 3 from being displayed even if they have attempted two fetch subscriptions.
This will probably not be a huge deal since I imagine it rarely happens.
The alternatives is to check if the user has attempted to refresh subscriptions.

Screenshots

This is the message that shows when the setting is disabled and the user starts the app or navigates to a new profile.

Testing

I created 2 new profiles
one without any channels to test if message 1 is displayed
the second one included only a channel without any videos to test if message 3 is displayed.

with the new setting disabled
I tested to make sure subscriptions where not fetched when freetube is started.
I switched between profiles to make sure subscriptions where not fetched automatically
I fetched subscriptions from one profile switched to another and the switched back to see if the video list was kept.

chosen api or rss should not affect anything since this check is done before that part of the code.

Desktop

OS: Arch Linux
OS Version: 5.19.8-arch1-1
FreeTube version: 0.17.1

Additional context

It's likely that I've missed something or implemented this weirdly since I am unfamiliar with this part of the code.

I had to remove the newline for the Your Subscription list is currently empty string in the locale file to get the new strings to work.

If disabling fetching when switching profile is unwanted I could make a new setting for that or just remove it.

Aiz0 · 2022-09-28T01:14:24Z

Accidentally opened this before filling in the template... It's filled in now so I'll reopen it.

PikachuEXE

Code changes look fine
Still need to test locally tomorrow (21:08 here)

PikachuEXE

Tested

Main changes
Profile with no channel for message 1
Switching between profiles to see fetched video list kept

message 3 not tested since no channel with no video provided

ChunkyProgrammer · 2022-09-29T01:49:32Z

src/renderer/components/subscription-settings/subscription-settings.vue

@@ -14,6 +14,12 @@
        :tooltip="$t('Tooltips.Subscription Settings.Fetch Feeds from RSS')"
        @change="updateUseRssFeeds"
      />
+      <ft-toggle-switch


I think you should add a switch column grid and two switch columns so it matches the layout of other setting components (parental control settings, distraction free settings, privacy settings, player settings)

I've added one now, It does look nicer.

Should I change their order?

Aiz0 · 2022-09-29T16:43:16Z

message 3 not tested since no channel with no video provided

Sorry forgot to include a one. Didn't want to pick a random users channel.
Youtube music channel works though since it's a special channel without any videos uploaded.
https://www.youtube.com/channel/UC-9-kyTW8ZkZNDHQJ6FgpwQ

This matches the layout other settings components

src/renderer/components/subscription-settings/subscription-settings.vue

used so the disable automatic fetch message doesn't block the empty channels message.

Aiz0 · 2022-09-29T17:19:10Z

I was over complicating this in my mind...
The correct message should now display in all cases.

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-09-29T20:09:16Z

static/locales/en-US.yaml

@@ -768,6 +770,8 @@ Tooltips:
    Fetch Feeds from RSS: When enabled, FreeTube will use RSS instead of its default
      method for grabbing your subscription feed. RSS is faster and prevents IP blocking,
      but doesn't provide certain information like video duration or live status
+    Fetch Automatically: When enabled, FreeTube will automatically fetch
+      your subscription feed on start and when switching profile.


Not sure if important to mention but feed will also be fetched when opening a new window/tab
Also not a big fan of the space between this setting and the RSS setting

The visual space between them can be fixed by adding the :compact="true" attribute to all 3 switches.

Not sure if important to mention but feed will also be fetched when opening a new window/tab

I don't think "on start" is the best wording.
I'll see if I can think of something better or if there's any suggestions.
Maybe "when a window is opened" or something.

The visual space between them can be fixed by adding the :compact="true" attribute to all 3 switches.

Thanks, I'll add that.

I've made the switches compact and reworded the tooltip.

efb4f5ff-1298-471a-8973-3d47447115dc

Some observations

PikachuEXE

All tested locally

Aiz0 added 4 commits September 27, 2022 02:37

Add setting to disable automatic fetching of subscriptions

be38b6b

rename from load to fetch. fix profile switch auto fetching

e5c8729

add message for when auto fetch is disabled

96ae3ee

add strings to locale file

bb575d9

PrestonN enabled auto-merge (squash) September 28, 2022 00:03

Aiz0 closed this Sep 28, 2022

auto-merge was automatically disabled September 28, 2022 00:03
Pull request was closed

Aiz0 reopened this Sep 28, 2022

PrestonN enabled auto-merge (squash) September 28, 2022 01:14

Aiz0 changed the title ~~Setting auto fetch feed~~ Add setting to disable automatic fetching of subscription feed Sep 28, 2022

ChunkyProgrammer added B: inconsistent behavior PR: waiting for review For PRs that are complete, tested, and ready for review and removed B: inconsistent behavior labels Sep 28, 2022

ChunkyProgrammer requested review from efb4f5ff-1298-471a-8973-3d47447115dc, absidue, ChunkyProgrammer and PikachuEXE September 28, 2022 11:15

PikachuEXE reviewed Sep 28, 2022

View reviewed changes

PikachuEXE previously approved these changes Sep 29, 2022

View reviewed changes

ChunkyProgrammer reviewed Sep 29, 2022

View reviewed changes

Use a switch column grid for the subscription settings

d739087

This matches the layout other settings components

auto-merge was automatically disabled September 29, 2022 16:53
Head branch was pushed to by a user without write access

Aiz0 dismissed PikachuEXE’s stale review via d739087 September 29, 2022 16:53

PrestonN enabled auto-merge (squash) September 29, 2022 16:53

absidue reviewed Sep 29, 2022

View reviewed changes

src/renderer/components/subscription-settings/subscription-settings.vue Show resolved Hide resolved

remove import of now unused ft-flex-box component

5cca29e

auto-merge was automatically disabled September 29, 2022 17:06
Head branch was pushed to by a user without write access

PrestonN enabled auto-merge (squash) September 29, 2022 17:07

add variable to track if an attempt to fetch has been made.

42bb039

used so the disable automatic fetch message doesn't block the empty channels message.

auto-merge was automatically disabled September 29, 2022 17:14
Head branch was pushed to by a user without write access

PrestonN enabled auto-merge (squash) September 29, 2022 17:15

absidue previously approved these changes Sep 29, 2022

View reviewed changes

ChunkyProgrammer previously approved these changes Sep 29, 2022

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc requested a review from PikachuEXE September 29, 2022 20:03

efb4f5ff-1298-471a-8973-3d47447115dc reviewed Sep 29, 2022

View reviewed changes

Aiz0 added 2 commits September 29, 2022 23:21

reduce distance between switches by adding compact=true

23703e9

edit tooltip wording

ddde14b

auto-merge was automatically disabled September 29, 2022 22:12
Head branch was pushed to by a user without write access

Aiz0 dismissed stale reviews from ChunkyProgrammer and absidue via ddde14b September 29, 2022 22:12

PrestonN enabled auto-merge (squash) September 29, 2022 22:12

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Sep 29, 2022

View reviewed changes

PikachuEXE approved these changes Sep 30, 2022

View reviewed changes

ChunkyProgrammer approved these changes Sep 30, 2022

View reviewed changes

PrestonN merged commit 6ddbce2 into FreeTubeApp:development Sep 30, 2022

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 30, 2022

Aiz0 deleted the setting-auto-fetch-feed branch October 8, 2022 00:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add setting to disable automatic fetching of subscription feed #2632

Add setting to disable automatic fetching of subscription feed #2632

Aiz0 commented Sep 28, 2022 •

edited

Loading

Aiz0 commented Sep 28, 2022

PikachuEXE left a comment

PikachuEXE left a comment

ChunkyProgrammer Sep 29, 2022

Aiz0 Sep 29, 2022

Aiz0 commented Sep 29, 2022

Aiz0 commented Sep 29, 2022

efb4f5ff-1298-471a-8973-3d47447115dc Sep 29, 2022 •

edited

Loading

absidue Sep 29, 2022

Aiz0 Sep 29, 2022

Aiz0 Sep 29, 2022

Aiz0 Sep 29, 2022

efb4f5ff-1298-471a-8973-3d47447115dc left a comment •

edited

Loading

PikachuEXE left a comment

Add setting to disable automatic fetching of subscription feed #2632

Add setting to disable automatic fetching of subscription feed #2632

Conversation

Aiz0 commented Sep 28, 2022 • edited Loading

Add setting to disable automatic fetching of subscription feed

Pull Request Type

Related issue

Description

Main changes

other stuff

Screenshots

Testing

Desktop

Additional context

Aiz0 commented Sep 28, 2022

PikachuEXE left a comment

Choose a reason for hiding this comment

PikachuEXE left a comment

Choose a reason for hiding this comment

ChunkyProgrammer Sep 29, 2022

Choose a reason for hiding this comment

Aiz0 Sep 29, 2022

Choose a reason for hiding this comment

Aiz0 commented Sep 29, 2022

Aiz0 commented Sep 29, 2022

efb4f5ff-1298-471a-8973-3d47447115dc Sep 29, 2022 • edited Loading

Choose a reason for hiding this comment

absidue Sep 29, 2022

Choose a reason for hiding this comment

Aiz0 Sep 29, 2022

Choose a reason for hiding this comment

Aiz0 Sep 29, 2022

Choose a reason for hiding this comment

Aiz0 Sep 29, 2022

Choose a reason for hiding this comment

efb4f5ff-1298-471a-8973-3d47447115dc left a comment • edited Loading

Choose a reason for hiding this comment

PikachuEXE left a comment

Choose a reason for hiding this comment

Aiz0 commented Sep 28, 2022 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc Sep 29, 2022 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc left a comment •

edited

Loading