Prevent search from closing when using a virtual keyboard #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from closing the search bar
github-actions
bot
added
the
PR: waiting for review
|
Regarding Additional Context: This would probably also be benefitial for the pinephone which is supported by FreeTube as well as some laptops so I don't think this would need to check if IS_ELECTRON is false |
ChunkyProgrammer
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
absidue
approved these changes
Oct 3, 2022
PikachuEXE
approved these changes
Oct 4, 2022
github-actions
bot
removed
the
PR: waiting for review
MarmadileManteater
deleted the
fix-search-disappearing-when-using-a-virtual-keyboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent search from closing when using a virtual keyboard
Pull Request Type
Description
This PR adds a condition to the window
resizeevent listener which prevents the search bar from closing unless the width of the page has changed. On mobile, the screen height may change when opening a virtual keyboard, but the screen width does not typically change. This change should prevent issues with the search bar closing when opening a virtual keyboard.Screenshots
before (on Android in my fork)
after (on Android in my fork)
Desktop (please complete the following information):
Additional context
This would also effect Electron builds. I am open to modifying this PR to only change the existing behavior when
IS_ELECTRONisfalseif that would make more sense.