Add setting to toggle Enter fullscreen on rotate
#2808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setting to toggle
Enter fullscreen on rotate
Pull Request Type
Related issue
Closes #2806
Description
This PR adds a new setting called
Enter fullscreen on display rotate
. This setting defaults tofalse
, and this should prevent the video from entering fullscreen when the window is dragged across multi-monitor setups with portrait and landscape displays because AFAIK there is no scenario where someone would have multiple monitors and want to have this setting on.Screenshots
before:
after:
Testing
This can be tested on dual monitor setups with one portrait and one landscape display.
It would also probably be worth testing that the setting works when enabled:
Enter fullscreen on rotate
underPlayer Settings
Or, I guess if you are really trying to be thorough about it:
yarn dev:web
9080
from a browser on a phone or tablet connected to your networkEnter fullscreen on rotate
underPlayer Settings
videojs-mobile-ui
is active and workingDesktop