Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exempt some labels from stale workflow #2812

Closed
wants to merge 1 commit into from
Closed

exempt some labels from stale workflow #2812

wants to merge 1 commit into from

Conversation

ChunkyProgrammer
Copy link
Member

exempt some labels from stale workflow

Pull Request Type

  • Other - workflow

Description

I don't feel that the stale workflow should apply to feature requests or PRs that are waiting for review

Testing

Tested in the FreeTube test repo

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

Additional context

Let me know if you agree/disagree with the changes 😃

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 3, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 3, 2022 19:28
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

I agree because it is logical to review a PR when we have time for it but i also disagree because if a PR with that label gets stale after a month it means that we are slacking and should really review it.

I disagree with the issue because i already found many duplicate issues thanks to the stale bot saying, hi this is stale. If something like that is stale i often investigate if its a valid request and if this could be a duplicate of another issue

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Nov 3, 2022
@PikachuEXE
Copy link
Collaborator

Agree with @efb4f5ff-1298-471a-8973-3d47447115dc
The bot also agrees /s

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

If needed i will summon all the bots for this battle

Merged
1 task
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the U: duplicate This issue or pull request already exists label Nov 4, 2022
@ChunkyProgrammer
Copy link
Member Author

I agree because it is logical to review a PR when we have time for it but i also disagree because if a PR with that label gets stale after a month it means that we are slacking and should really review it.

I disagree with the issue because i already found many duplicate issues thanks to the stale bot saying, hi this is stale. If something like that is stale i often investigate if its a valid request and if this could be a duplicate of another issue

Do you think we should have a seperate label we can assign to issues to prevent it from going stale?

@PikachuEXE
Copy link
Collaborator

That would be useful

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 6, 2022 •
edited
Loading

Do you think we should have a seperate label we can assign to issues to prevent it from going stale?

I think that is a good idea. Maybe we can also use a label for our own PR's that have been laying around for a while? If we go this route i suggest skipping the stale check on PRs when it has a WIP label

auto-merge was automatically disabled December 4, 2022 20:14

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 4, 2022
This was referenced Dec 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE