Fix emoji display in the profile selector #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Nov 4, 2022
ChunkyProgrammer
approved these changes
Nov 4, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 4, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix emoji display in the profile selector
Pull Request Type
Related issue
Closes #2813
Introduced in #2664
Description
Turns out that
'string'[0]extracts the character before parsing emojis, so you end up with the emoji split up into it's individual character codes (same with'string'.split('')). Array.from on the other hand creates the array after parsing the emojis.Screenshots
Testing
Create a profile with an emoji as the first character
Check that the emojis shows up in the profile selector and in the top right when the profile is selected
Desktop