Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chapter marker placement #2874

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Nov 19, 2022

Fix chapter marker placement

Pull Request Type

  • Bugfix

Description

This pull request lines the chapter markers up with the start of the chapters.

Screenshots

before
after

Testing

https://youtu.be/k-6yc1dA--0

Use the chapters list to seek to various chapters and check that the markers line up with the start of the chapters.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 19, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 19, 2022 11:43
@absidue absidue disabled auto-merge November 20, 2022 12:37
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 20, 2022 12:37
@FreeTubeBot FreeTubeBot merged commit 88e9618 into FreeTubeApp:development Nov 20, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2022
@absidue absidue deleted the chapter-marker-placement branch November 21, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants