Hide unsubscribe button on channel list if this is set in parental controls. #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
December 2, 2022 18:09
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
December 2, 2022 18:14
Head branch was pushed to by a user without write access
|
Hi, good catch. Would you be able to remove the package-lock.json file? Thank you for opening this PR 🙂 |
auto-merge was automatically disabled
December 3, 2022 08:07
Head branch was pushed to by a user without write access
|
Hi - sorry about that I have removed it now. |
ChunkyProgrammer
requested review from
ChunkyProgrammer,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
ChunkyProgrammer
approved these changes
Dec 3, 2022
absidue
approved these changes
Dec 4, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Hide unsubscribe button on channel list if this is set in parental controls.
Pull Request Type
Related issue
#1086
Description
There is an existing parental control setting to hide the unsubscribe button on the channel page. This PR also hides the unsubscribe button on the channel list page (the channels page in the side bar).
Testing
I tested this PR by building the app and observing that the unsubscribe button was hidden on the channel page and the channels page when the setting was toggled in the parental control settings panel. I also observed that the unsubscribe button was not hidden when this setting is not enabled.
Desktop
Additional context
None