Only show the load more comments button when necessary #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Dec 5, 2022
PikachuEXE
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Also tested with limited of pages
https://youtu.be/-erMT-LvWz8 - 2 pages
|
Only a thought that occurred to me a few days ago: it might also be worth adding a label with "No More Comments", otherwise some users may not be aware of why the |
|
Let's merge this first and add it later? |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 6, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the load more comments button when necessary
Pull Request Type
Related issue
closes #2894
Description
Only show the "Load More Comments" button if there are more comments available, otherwise hide it.
Testing
Video from the issue with only one page of comments: https://youtu.be/rKOkJqUWnPM
LTT video with lots of comments: https://youtu.be/OHKKcd3sx2c
Desktop