Add QT Url support for freetube protocol #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
requested changes
Jan 27, 2023
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
previously approved these changes
Jan 27, 2023
PikachuEXE
reviewed
Jan 27, 2023
PikachuEXE
approved these changes
Jan 27, 2023
absidue
approved these changes
Jan 27, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 27, 2023
github-actions
bot
removed
the
PR: waiting for review
|
I have tested this solution and can confirm that it solves the problem. |
Thanka for testing, I'm glad it fixed the issue for you 🙂 |
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QT Url support for FreeTube protocol
Pull Request Type
Related issue
libredirect/browser_extension#212
#373 (comment)
Description
The way QT parses the url, it removes the : after https as it recognizes "freetube://" as the protocol.
This PR makes it so that "freetube:" can be used as the protocol instead and will readd the missing colon after the 'https'
Testing
None, I don't use QT (I use Windows)
Desktop