Reduce overflow in playlist view #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
absidue,
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
absidue
approved these changes
Jan 29, 2023
ChunkyProgrammer
approved these changes
Jan 29, 2023
PikachuEXE
approved these changes
Jan 30, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce overflow in playlist view
Pull Request Type
Description
The videos in the playlist view overflow the screen if the window is narrow enough ( < 550px). They also overflow their container when the screen is between 850px~1000px wide. This PR aims to address these things by making the thumbnail images more responsive.
Screenshots
Testing
Desktop
Additional Information
I adjusted the
ft-list-itemstyles to be more specific. The thumbnail Image had transitions for all of its properties (including width), so I made it more specific to avoid issues with the width animating for thumbnail images on videos which have already been watched.