Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secondary colour theme for all share buttons #3169

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Feb 7, 2023

Use secondary colour theme for all share buttons

Pull Request Type

  • Feature Implementation

Related issue

closes #3162

Description

This pull request makes the share button consistently themed throughout FreeTube.

Screenshots

Playlist:
playlist-before playlist-after

Channel:
channel-before channel-after

Testing

Video: https://youtu.be/mWEE2RJj3YI
Channel: https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw
Playlist: https://www.youtube.com/playlist?list=PL8mG-RkN2uTzE4GpbGQ8J0p_p91D9oWQT

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 7, 2023 21:57
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 7, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@FreeTubeBot FreeTubeBot merged commit 36c42f0 into FreeTubeApp:development Feb 8, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 8, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc

@PikachuEXE Damn, that squad was legendary. U really giving me nostalgic feeling with this one. Also the pics u post always brighten my day :D

@absidue absidue deleted the share-button-theme branch February 8, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Share button colour on channel and playlist page should be based on Secondary Colour Theme
5 participants