Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Channel age restricted key #3237

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Update Channel age restricted key #3237

merged 2 commits into from
Apr 10, 2023

Conversation

yarons
Copy link
Contributor

@yarons yarons commented Mar 1, 2023

Typo fixed

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 1, 2023 06:30
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 1, 2023
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locale files should be updated too
image

@yarons
Copy link
Contributor Author

yarons commented Mar 1, 2023

Those lines are not automatically generated and replaced according to a base template?

@absidue
Copy link
Member

absidue commented Mar 1, 2023

@yarons the localisations work like a key value store, so when you change the key in the code, you also need to change the keys in the translation files, otherwise it will fallback to displaying Channel["This channel is age restricted and currently cannot be viewed in FreeTube."] as it can't find that key in any translation files.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 1, 2023
@ChunkyProgrammer ChunkyProgrammer changed the title Update Channel.js Update Channel age restricted key Mar 29, 2023
@absidue
Copy link
Member

absidue commented Apr 1, 2023

Hey @yarons
Do you have plans to continue working on this pull request?

@yarons
Copy link
Contributor Author

yarons commented Apr 1, 2023

Hey, no, it's a typo fix, nothing further.

@absidue
Copy link
Member

absidue commented Apr 1, 2023

Okay, would you be alright with me taking it over (updating the rest of the files)?

@yarons
Copy link
Contributor Author

yarons commented Apr 1, 2023

Sure, sorry about the hassle.

@absidue absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Apr 9, 2023
@FreeTubeBot FreeTubeBot merged commit c4f6033 into FreeTubeApp:development Apr 10, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Apr 17, 2023
* development:
  Add 50fps and live support to frame by frame keyboard shortcuts (FreeTubeApp#3420)
  Remove invidious.namazso.eu in dev branch (FreeTubeApp#3425)
  Cleanup polyfills (FreeTubeApp#3383)
  Small community post fixes (FreeTubeApp#3401)
  Bump rimraf from 4.4.1 to 5.0.0 (FreeTubeApp#3409)
  Bump peter-evans/create-pull-request from 4 to 5 (FreeTubeApp#3414)
  Bump eslint from 8.37.0 to 8.38.0 (FreeTubeApp#3416)
  Bump lefthook from 1.3.8 to 1.3.9 (FreeTubeApp#3410)
  Bump webpack from 5.77.0 to 5.78.0 (FreeTubeApp#3411)
  Bump youtubei.js from 4.1.1 to 4.2.0 (FreeTubeApp#3412)
  Bump sass from 1.60.0 to 1.61.0 (FreeTubeApp#3413)
  Update Channel age restricted key (FreeTubeApp#3237)
  Fix some translation entries sometimes not used when rendered (FreeTubeApp#3337)
  Reset current chapter index when changing videos (FreeTubeApp#3400)
@yarons yarons deleted the patch-1 branch August 21, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants