Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly show live and upcoming videos in playlists and up next #3250

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Mar 3, 2023

Properly show live and upcoming videos in playlists and up next

Pull Request Type

  • Feature Implementation

Description

YouTube.js didn't have these fields back when I migrated the watch and playlist pages over, so now that they are here we might as well use them.

Screenshots

before-upcoming
after-upcoming

before-live
after-live

Testing

Upcoming Live Streams playlist
https://www.youtube.com/playlist?list=PLU12uITxBEPHHlOIWGAIezbshH82rGpKp

Live playlist
https://www.youtube.com/playlist?list=PLU12uITxBEPHOJO1FU8qll6gQmKcXp5S7

Potential live streams in the Up Next section
https://www.youtube.com/watch?v=rUxyKA_-grg

couldn't find a video with upcoming videos in the Up Next section

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 3, 2023 19:14
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 3, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local API tested
Nothing changed with Indivious API though

@FreeTubeBot FreeTubeBot merged commit 1335604 into FreeTubeApp:development Mar 5, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 5, 2023
@absidue absidue deleted the live-upcoming-playlists-up-next branch March 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants