Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Live tab to channel pages #3273

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Add Live tab to channel pages #3273

merged 4 commits into from
Mar 15, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Mar 7, 2023

Add Live tab to channel pages

Pull Request Type

  • Feature Implementation

Related issue

Partially addresses #2852

Description

This pull request adds the live tab to the channel pages, the tab will be hidden and inaccessible when the hide live streams distraction free setting is enabled.

Screenshots

live-tab

Testing

Make sure the hide live streams distraction free setting is disabled

Channel with live tab: https://youtube.com/@LinusTechTips
Channel without live tab: https://youtube.com/@TheyreJustMovies
Direct link to live tab: https://youtube.com/@LinusTechTips/live

Enable the hide live streams distraction free setting
Check that the live tab is hidden
Check that the videos tab is selected when you try to use a direct link to the live tab: https://youtube.com/@LinusTechTips/live

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 7, 2023 18:35
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 7, 2023
ChunkyProgrammer
ChunkyProgrammer previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@PikachuEXE
Copy link
Collaborator

Channel with live tab: https://youtube.com/@LinusTechTips - OK

Channel without live tab: https://youtube.com/@TheyreJustMovies

Live tab still visible AND showing different channel content (I visited https://youtube.com/@LinusTechTips first)
image

This shows if I visit https://youtube.com/@TheyreJustMovies without visiting other channels first
image

Direct link to live tab: https://youtube.com/@LinusTechTips/live - OK

Enable the hide live streams distraction free setting
Check that the live tab is hidden
Check that the videos tab is selected when you try to use a direct link to the live tab: https://youtube.com/@LinusTechTips/live

All OK

@ChunkyProgrammer ChunkyProgrammer self-requested a review March 8, 2023 01:01
@ChunkyProgrammer ChunkyProgrammer added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 8, 2023
@absidue absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Mar 8, 2023
PikachuEXE
PikachuEXE previously approved these changes Mar 10, 2023
View reviewed changes
@PikachuEXE
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc
image

@absidue absidue mentioned this pull request Mar 11, 2023
Closed
4 tasks
@absidue absidue dismissed stale reviews from PikachuEXE and ChunkyProgrammer via 03b99f4 March 12, 2023 12:00
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works like expected, LGTM.

@PikachuEXE
Copy link
Collaborator

Got this error on https://www.youtube.com/channel/UCrfKGpvbEQXcbe68dzXgJuA/live, when switching sort to most popular
image

@ChunkyProgrammer
Copy link
Member

Got this error on https://www.youtube.com/channel/UCrfKGpvbEQXcbe68dzXgJuA/live, when switching sort to most popular

The sort button doesn't appear on youtube for that channel when looking at live streams

@absidue
Copy link
Member Author

absidue commented Mar 14, 2023

That sorting problem is the same as in this issue: #3251

The question is: Do you want me to wait until this pull request is merged and then do a pull request to fix it for all channel tabs in one go or do fix it for the live tab in this pull request and create a second pull request for the videos and playlists tab?

@ChunkyProgrammer
Copy link
Member

IMO it can be fixed in a future PR

PikachuEXE
PikachuEXE approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if the issue is already reported in #3251

@FreeTubeBot FreeTubeBot merged commit 0212467 into FreeTubeApp:development Mar 15, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 15, 2023
@absidue absidue deleted the channel-live-tab branch March 15, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot