Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message when the live chat is unavailable #3327

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Show message when the live chat is unavailable #3327

merged 2 commits into from
Mar 23, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Mar 19, 2023 •
edited
Loading

Show message when the live chat is unavailable

Pull Request Type

  • Bugfix

Related issue

closes #3309

Description

Currently if an uploader has disabled the live chat for a live stream or if it is unavailable for some other reason, FreeTube spits out an error. This pull request detects if the live chat is missing and shows a message to the user instead of spitting out an error.

Screenshots

live-chat-unavailable

Testing

Find a live stream on https://youtube.com/live that has the live chat disabled. (I'm not going to link specific ones, as the ones I found while reproducing the issue, will have probably ended by the time you test this pull request).

Please test with the local API, the Invidious API with backend fallback enabled and the Invidious API with backend fallback disabled, as they all function slightly differently.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 029f0cb

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 19, 2023 18:53
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 19, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior was the same and got this error

Capture

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PikachuEXE
Copy link
Collaborator

I have difficulty finding one without live chat
image

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, could u maybe make the message box smaller? I think it would be nice for the user to see the Up Next section instead of having to scroll down for it

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 20, 2023 •
edited
Loading

I have difficulty finding one without live chat

@PikachuEXE Search in the live stream playlists for news outlets. They almost always disable the chat

@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Mar 21, 2023 •
edited
Loading

Off topic: found this
image
image

yarn dev only?

Update 1: PR created - #3337

PikachuEXE
PikachuEXE previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested local API, the Invidious API with backend fallback enabled and the Invidious API with backend fallback disabled

@PikachuEXE PikachuEXE mentioned this pull request Mar 21, 2023
Merged
4 tasks
@absidue
Copy link
Member Author

absidue commented Mar 21, 2023

On a second thought, could u maybe make the message box smaller? I think it would be nice for the user to see the Up Next section instead of having to scroll down for it

If there is an error it will now shrink, so that it doesn't take up an unnecessary amount of space.

@PikachuEXE
Copy link
Collaborator

How to test "message box smaller on error"?
I tried all "local API, the Invidious API with backend fallback enabled and the Invidious API with backend fallback disabled" already

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@PikachuEXE before the message box was the same size as an active life chat but know it is way smaller if it is disabled.

PikachuEXE
PikachuEXE approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@FreeTubeBot FreeTubeBot merged commit 8366ec9 into FreeTubeApp:development Mar 23, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 23, 2023
@absidue absidue deleted the live-chat-disabled branch March 23, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: Cannot read properties of null (reading 'once')
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot